Added Symptoms onset date field in encounters overview #10759

hrit2773 · 2025-02-22T04:50:28Z

Proposed Changes

Fixes Encounters Overview: Symptoms onset date is not displayed #10673
Change 1
Change 2
More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Updated the symptoms table to conditionally display the patient's onset date in a locale-specific format, with a placeholder shown if no date is available.
Refactor
- Removed the previous verification status indicator to streamline the presentation.

coderabbitai · 2025-02-22T04:50:36Z

Walkthrough

The pull request updates the symptom table component by adding a new table header and cell for displaying the onset date of symptoms. A new <TableHead> element for the "onset" column is introduced, along with a <TableCell> that conditionally renders the formatted onset date as a locale-specific date string or a hyphen if the date is not available.

Changes

File	Change Summary
`src/components/Patient/symptoms/SymptomTable.tsx`	Added a new `<TableHead>` for the "onset" column and a `<TableCell>` that conditionally displays the formatted onset date or a hyphen if not present.

Possibly related PRs

Minor Changes In Encounter Page #10017: The changes in the main PR for the SymptomTable.tsx file, which involve adding a new table header for the onset date and modifying the rendering logic for the created by field, are related to the changes in the retrieved PR that also involve the SymptomTable.tsx file, specifically updating the "Created By" column rendering and localizing table headers.

Suggested labels

needs review, tested

Suggested reviewers

amjithtitus09
rithviknishad

Poem

Hopping through lines of code so bright,
A new header for onset, what a delight!
Dates now displayed, in locale's embrace,
A table transformed, with style and grace.
A rabbit’s cheer for each change we write! 🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 10f779b and 4be8d1b.

📒 Files selected for processing (1)

src/components/Patient/symptoms/SymptomTable.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Patient/symptoms/SymptomTable.tsx

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: Redirect rules - care-ohc
GitHub Check: Header rules - care-ohc
GitHub Check: Pages changed - care-ohc
GitHub Check: Test
GitHub Check: OSSAR-Scan
GitHub Check: cypress-run (1)
GitHub Check: CodeQL-Build

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-22T04:50:44Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`dbf6156`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67bd82eb28974f0008c0e9a6
😎 Deploy Preview	https://deploy-preview-10759.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 327a2b8 and 10f779b.

📒 Files selected for processing (1)

src/components/Patient/symptoms/SymptomTable.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (1)

src/components/Patient/symptoms/SymptomTable.tsx (1)

50-50: LGTM! The header is properly internationalized.

The new "onset" column header follows the existing pattern of using i18n translation and maintains consistent styling.

coderabbitai · 2025-02-22T04:54:49Z

src/components/Patient/symptoms/SymptomTable.tsx

+            <TableCell className="whitespace-nowrap">
+              {symptom.onset?.onset_datetime
+                ? new Date(symptom.onset.onset_datetime).toLocaleDateString()
+                : "-"}


🛠️ Refactor suggestion

Improve date formatting and handling.

While the implementation works, consider these improvements for better date handling:

Specify format options for consistent date display across locales

Add timezone handling

Add date validation

Here's a suggested implementation:

<TableCell className="whitespace-nowrap"> - {symptom.onset?.onset_datetime - ? new Date(symptom.onset.onset_datetime).toLocaleDateString() - : "-"} + {symptom.onset?.onset_datetime + ? (() => { + const date = new Date(symptom.onset.onset_datetime); + return !isNaN(date.getTime()) + ? date.toLocaleDateString(undefined, { + year: 'numeric', + month: 'short', + day: 'numeric' + }) + : "-" + })() + : "-"} </TableCell>

This change:

Validates the date before formatting

Ensures consistent date format across locales

Uses IIFE to keep the code clean while adding validation

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

<TableCell className="whitespace-nowrap">

{symptom.onset?.onset_datetime

? new Date(symptom.onset.onset_datetime).toLocaleDateString()

: "-"}

<TableCell className="whitespace-nowrap">

{symptom.onset?.onset_datetime

? (() => {

const date = new Date(symptom.onset.onset_datetime);

return !isNaN(date.getTime())

? date.toLocaleDateString(undefined, {

year: 'numeric',

month: 'short',

day: 'numeric'

})

: "-"

})()

: "-"}

</TableCell>

hrit2773 · 2025-02-22T04:55:02Z

@Jacobjeevan @rithviknishad made changes according to the format suggested by @amjithtitus09

src/components/Patient/symptoms/SymptomTable.tsx

hrit2773 · 2025-02-23T10:32:37Z

@amjithtitus09 fixed it back

nihal467 · 2025-02-25T07:28:34Z

LGTM

github-actions · 2025-02-25T12:21:48Z

@hrit2773 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

)

hrit2773 and others added 2 commits February 22, 2025 10:16

Added symptoms onset in encounters overview

bc11568

Merge branch 'ohcnetwork:develop' into branch1

10f779b

hrit2773 requested a review from a team as a code owner February 22, 2025 04:50

coderabbitai bot reviewed Feb 22, 2025

View reviewed changes

rithviknishad approved these changes Feb 22, 2025

View reviewed changes

rithviknishad added needs testing needs review labels Feb 22, 2025

amjithtitus09 requested changes Feb 22, 2025

View reviewed changes

src/components/Patient/symptoms/SymptomTable.tsx Show resolved Hide resolved

amjithtitus09 added work-in-progress and removed needs testing needs review labels Feb 23, 2025

verification got back

4be8d1b

hrit2773 requested review from amjithtitus09 and rithviknishad February 23, 2025 10:32

amjithtitus09 approved these changes Feb 24, 2025

View reviewed changes

amjithtitus09 added needs testing reviewed reviewed by a core member and removed work-in-progress labels Feb 24, 2025

amjithtitus09 assigned nihal467 Feb 24, 2025

nihal467 added tested and removed needs testing labels Feb 25, 2025

nihal467 removed their assignment Feb 25, 2025

Merge branch 'develop' into branch1

dbf6156

Jacobjeevan approved these changes Feb 25, 2025

View reviewed changes

Jacobjeevan merged commit dfeda14 into ohcnetwork:develop Feb 25, 2025
17 checks passed

ashwinpraveengo pushed a commit to ashwinpraveengo/care_fe that referenced this pull request Feb 26, 2025

Added Symptoms onset date field in encounters overview (ohcnetwork#10759

22ca3e7

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Symptoms onset date field in encounters overview #10759

Added Symptoms onset date field in encounters overview #10759

hrit2773 commented Feb 22, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 22, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 22, 2025 •

edited

Loading

coderabbitai bot left a comment

coderabbitai bot Feb 22, 2025

hrit2773 commented Feb 22, 2025

hrit2773 commented Feb 23, 2025

nihal467 commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

-            <TableCell className="whitespace-nowrap">
-              {symptom.onset?.onset_datetime
-                ? new Date(symptom.onset.onset_datetime).toLocaleDateString()
-                : "-"}
+            <TableCell className="whitespace-nowrap">
+              {symptom.onset?.onset_datetime
+                ? (() => {
+                    const date = new Date(symptom.onset.onset_datetime);
+                    return !isNaN(date.getTime())
+                      ? date.toLocaleDateString(undefined, {
+                          year: 'numeric',
+                          month: 'short',
+                          day: 'numeric'
+                        })
+                      : "-"
+                  })()
+                : "-"}
+            </TableCell>

Added Symptoms onset date field in encounters overview #10759

Added Symptoms onset date field in encounters overview #10759

Conversation

hrit2773 commented Feb 22, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 22, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 22, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Feb 22, 2025

Choose a reason for hiding this comment

hrit2773 commented Feb 22, 2025

hrit2773 commented Feb 23, 2025

nihal467 commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

hrit2773 commented Feb 22, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 22, 2025 •

edited

Loading