Loading medibase and icd11 static json and migrations #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sainak
reviewed
Mar 30, 2024
| update_fields=[ | ||
| "created_date", | ||
| "modified_date", | ||
| "deleted", |
| @@ -24,6 +24,7 @@ def handle(self, *args, **options): | |||
| MedibaseMedicine.objects.bulk_create( | |||
There was a problem hiding this comment.
add a check to fallback to bulk create only if there are no medicines in the db to speed up the process
| data = json.load(f) | ||
|
|
||
| for medicine in data: | ||
| m = MedibaseMedicine.objects.get(name=medicine["name"]) |
There was a problem hiding this comment.
create in case of DoesNotExists error
# Conflicts: # data/medibase.json
|
@sainak either complete or close this MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
1.Updated medibase.json
2.Updated
MedibaseMedicinemodel , removed external_id3.Updated
python manage.py load_redis_indexcommand to directly use the json to populate the redis4.Migrate all related models to use id as fk instead of external_id
Associated Issue
Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins