-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading medibase and icd11 static json #1927
Closed
DraKen0009
wants to merge
9
commits into
ohcnetwork:master
from
DraKen0009:loading-medibase-and-icd11-static-json
Closed
Loading medibase and icd11 static json #1927
DraKen0009
wants to merge
9
commits into
ohcnetwork:master
from
DraKen0009:loading-medibase-and-icd11-static-json
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please let me know if i missed any use of external_id in reference to |
sainak
reviewed
Feb 29, 2024
care/facility/static_data/icd11.py
Outdated
ICD11( | ||
id=icd11_id_to_int(diagnosis.get("ID")), | ||
label=diagnosis.get("label"), | ||
chapter=diagnosis.get("meta_chapter_short", ""), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@DraKen0009 extract the logic from the management command to a common utils file the migrations will be complex
|
contd. #1941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
1.Updated medibase.json
2.Updated
MedibaseMedicine
model , removed external_id3.Updated
python manage.py load_redis_index
command to directly use the json to populate the redis4.Migrate all related models to use id as fk instead of external_id [ working on it ]
Associated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins