Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env vars to configure cors headers #1703

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Nov 7, 2023

Proposed Changes

  • add a variable CORS_ALLOWED_ORIGINS to configure allowed cors hosts

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak mentioned this pull request Nov 7, 2023
3 tasks
@sainak
Copy link
Member Author

sainak commented Nov 7, 2023

@gigincg are there any other hosts that make cors request to the backend apart from https://github.com/coronasafe/care/pull/1703/files#diff-f7f3169854bfaea4f6e2c43c585659c684153dd3fd92f4ea22b889954793984eR38

@vigneshhari
Copy link
Member

Caution!, This needs to be mentioned in the release note.

@vigneshhari vigneshhari merged commit 261d024 into master Dec 7, 2023
5 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/cors-1 branch December 7, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants