New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cors headers in prod #1702

Closed

3 tasks

sainak opened this issue Nov 7, 2023 · 1 comment

Assignees

Member

sainak commented Nov 7, 2023 •

edited

Loading

currently we are sending multiple hostnames in acao header instead only the requesting host header should be returned

this is due to the acoa header hardcoded in nginx config in infra deployments

https://github.com/coronasafe/infra_template/blob/0686194e6cdc73c579971c0afa006772166d8446/configmaps/nginx.yaml#L113

but this should be handeled by django-cors-headers middleware
https://github.com/adamchainz/django-cors-headers

add env vars to configure cors headers #1703
update all instances to include the correct hostnames
remove hardcoded hostname from nginx config

sainak self-assigned this

sainak mentioned this issue

add env vars to configure cors headers #1703

Merged

4 tasks

Contributor

itxsoumya commented Feb 23, 2024

Hello, can I work on this issue ?

sainak closed this as not planned

sainak reopened this

sainak closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment