Provide an accessor for the form widget of the Settings controller #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Settings controller does not currently have any method to get the form widget or its data through normal means as the form widget is protected and does not use the normal FormController behavior. This prevents extensions to the controller from being able to manipulate the form. This adds a `formGetWidget` method (similar to the FormController behavior) that allows people to access the widget.
LukeTowers
reviewed
Jul 15, 2020
LukeTowers
reviewed
Jul 15, 2020
LukeTowers
reviewed
Jul 15, 2020
LukeTowers
reviewed
Jul 15, 2020
LukeTowers
reviewed
Jul 15, 2020
LukeTowers
reviewed
Jul 15, 2020
|
LGTM! |
|
Add this to the Laravel 6 wip release notes in the meta repo please too when merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #5209.
The Settings controller does not currently have any method to get the form widget or its data through normal means as the form widget is protected and does not use the normal FormController behavior.
This prevents extensions to the controller from being able to manipulate the form.
This adds a
formGetWidgetmethod (similar to the FormController behavior) that allows people to access the widget. As the form widget in the Settings controller is dependent on the URL to determine which plugin or module is being configured, a method to auto-guess the current model has also been added.