Reveal sensitive field if part of an AJAX request #5209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sensitive field currently does not work with AJAX requests correctly if it is unrevealed - it sends the hidden placeholder instead of the real value with AJAX requests. This change allows the sensitive field to intercept AJAX requests on elements within the same form, and reveals the field. Once revealed, it then replays the AJAX request on the original element, which should then pick up the sensitive field's true value in the form data.
|
@bennothommo could you provide an example of why you need the data present in an AJAX request? |
|
Closing in favour of #5212. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sensitive field currently does not work with AJAX requests correctly if it is unrevealed - it sends the hidden placeholder instead of the real value with AJAX requests.
This change allows the sensitive field to intercept AJAX requests on elements within the same form, and reveals the field. Once revealed, it then replays the AJAX request on the original element, which should then pick up the sensitive field's true value in the form data.