use barge instead of ganache #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please no. Please keep them separated so we do not wait for ages for every test. There is a reason I split them up and NOT using barge for the unit tests. If you need more than ganache for a test, it's an integration test. The mnemonic has not changed in 4 years... |
|
instead of running ganache:latest with some extra param, we run barge with ganache and without aqua/provider/es, etc.. |
|
alright, so Ganache with Barge starts up faster than Ganache directly from DockerHub so let's go with that |
kremalicious
approved these changes
Jun 22, 2021
kremalicious
added a commit
that referenced
this pull request
Jun 22, 2021
* GitHub CI actions * add coverage job * test run tweaks * windows build fix * barge tweaks * deal with env vars * add npm publish job * trial & error * remove Travis * publish as single workflow * handle Docker Hub login * maybe preparing ~/.ocean is needed * downgrade barge contracts, run with barge defaults * put back ADDRESS_FILE env var * AQUARIUS_URI test * ddo creation test logging * make failing DDO creation test actually fail * separate unit/integration Asset tests * set AQUARIUS_URI again * readme updates * prepare ~/.ocean folder * separate tests into multiple jobs * address.json debugging * windows build fixes * address.json trials * env var expansion workaround * cleanup * debug coverage output * fix coverage * bump codeclimate-action * use barge instead of ganache (#855) * use barge instead of ganache * small unit test job cleanup Co-authored-by: Matthias Kretschmann <m@kretschmann.io> * barge detach workaround Co-authored-by: Alex Coseru <alex.coseru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, let's use barge for unit tests as well
You can say that it's over engineered, but if we need to change the mnemonic, or activate/deactivate EIPS, we are going to do that in one repo (barge)