-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis with GitHub Actions #847
Conversation
5825333
to
b7e7814
Compare
I noticed that the CI tests failed in #842, I guess that's related to what you are testing/fixing here? |
yup, Travis is getting on my nerves failing for no particular reason so quickly doing sprint to figure out how quickly I can switch to GitHub Actions :-) Already catched a bug showing that ocean.js can't be built on Windows at all |
1deac86
to
23a9178
Compare
Btw there are multiple tests failing https://travis-ci.com/github/oceanprotocol/ocean.js/builds/229036382 , not sure what is the culprit here |
yeah it seems just random and most of the time Travis push build succeeds but Pull request build does not. We restarted runs multiple times and sometimes they succeeded and sometimes not. GitHub Actions would have great advantages including speed, made it so that publishing the npm package should be down from ~25min to ~3min cause it's independent now But for whatever reason the unit tests fail already on creating a datatoken https://github.com/oceanprotocol/ocean.js/runs/2838811916?check_suite_focus=true#step:11:175 Which made me believe the contracts in |
67cc8a7
to
da1808b
Compare
e6e2ee0
to
c583ba0
Compare
cf879bf
to
147e6e8
Compare
c7b5204
to
d23bed1
Compare
e4bdc9c
to
6392ec2
Compare
6392ec2
to
fb46b0c
Compare
4bd7456
to
833c1fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge #855 into this and we are good to go
* use barge instead of ganache * small unit test job cleanup Co-authored-by: Matthias Kretschmann <m@kretschmann.io>
interesting, so looks like the barge job does not "detach" if there's not something like |
Yeah, that is strange. but it works now :). |
Code Climate has analyzed commit 588d1c8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 80.0% (0.0% change). View more on Code Climate. |
CI
publish
, triggered on tag creation independent ofCI
run