Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with GitHub Actions #847

Merged
merged 32 commits into from
Jun 22, 2021
Merged

Conversation

kremalicious
Copy link
Contributor

@kremalicious kremalicious commented Jun 15, 2021

  • kick out Travis, move to GitHub Actions workflows
  • new workflow: CI
    • runs lint, build, unit tests, integration tests jobs, all independent of each other
  • new workflow: publish, triggered on tag creation independent of CI run
  • test build against all OS, fix building on Windows
  • separate unit & integration tests again. Rule of thumb: if test needs more than Ganache, it's an integration test
  • total CI run time down from ~21 min. to ~14 min.

Screen Shot 2021-06-21 at 13 17 57

@kremalicious kremalicious force-pushed the feature/github-actions branch 2 times, most recently from 5825333 to b7e7814 Compare June 15, 2021 13:09
@jamiehewitt15
Copy link
Member

I noticed that the CI tests failed in #842, I guess that's related to what you are testing/fixing here?

@kremalicious
Copy link
Contributor Author

kremalicious commented Jun 15, 2021

yup, Travis is getting on my nerves failing for no particular reason so quickly doing sprint to figure out how quickly I can switch to GitHub Actions :-)

Already catched a bug showing that ocean.js can't be built on Windows at all

@kremalicious kremalicious force-pushed the feature/github-actions branch 14 times, most recently from 1deac86 to 23a9178 Compare June 16, 2021 11:44
@kremalicious kremalicious changed the title Test GitHub CI actions Replace Travis with GitHub Actions Jun 16, 2021
@mihaisc
Copy link
Contributor

mihaisc commented Jun 16, 2021

Btw there are multiple tests failing https://travis-ci.com/github/oceanprotocol/ocean.js/builds/229036382 , not sure what is the culprit here

@kremalicious
Copy link
Contributor Author

kremalicious commented Jun 16, 2021

yeah it seems just random and most of the time Travis push build succeeds but Pull request build does not. We restarted runs multiple times and sometimes they succeeded and sometimes not. GitHub Actions would have great advantages including speed, made it so that publishing the npm package should be down from ~25min to ~3min cause it's independent now

But for whatever reason the unit tests fail already on creating a datatoken https://github.com/oceanprotocol/ocean.js/runs/2838811916?check_suite_focus=true#step:11:175

Which made me believe the contracts in address.json can't be read out or are wrong but by now pretty sure they are written out as can be seen here https://github.com/oceanprotocol/ocean.js/runs/2838811916?check_suite_focus=true#step:9:966

@kremalicious kremalicious force-pushed the feature/github-actions branch 3 times, most recently from 67cc8a7 to da1808b Compare June 17, 2021 09:46
@kremalicious kremalicious force-pushed the feature/github-actions branch from e6e2ee0 to c583ba0 Compare June 17, 2021 16:50
@kremalicious kremalicious force-pushed the feature/github-actions branch from cf879bf to 147e6e8 Compare June 17, 2021 17:15
@kremalicious kremalicious force-pushed the feature/github-actions branch from c7b5204 to d23bed1 Compare June 18, 2021 10:43
@kremalicious kremalicious marked this pull request as ready for review June 18, 2021 10:59
@kremalicious kremalicious force-pushed the feature/github-actions branch from e4bdc9c to 6392ec2 Compare June 19, 2021 10:06
@kremalicious kremalicious force-pushed the feature/github-actions branch from 6392ec2 to fb46b0c Compare June 19, 2021 10:24
@kremalicious kremalicious force-pushed the feature/github-actions branch from 4bd7456 to 833c1fb Compare June 19, 2021 12:28
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge #855 into this and we are good to go

* use barge instead of ganache

* small unit test job cleanup

Co-authored-by: Matthias Kretschmann <m@kretschmann.io>
@kremalicious
Copy link
Contributor Author

interesting, so looks like the barge job does not "detach" if there's not something like & cd .. at the end. That was the advantage of using pure docker command as that has a detach option which barge does not

@alexcos20
Copy link
Member

Yeah, that is strange. but it works now :).

@codeclimate
Copy link

codeclimate bot commented Jun 22, 2021

Code Climate has analyzed commit 588d1c8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.0% (0.0% change).

View more on Code Climate.

@kremalicious kremalicious merged commit d8914a8 into main Jun 22, 2021
@kremalicious kremalicious deleted the feature/github-actions branch June 22, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants