Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 668/documentation improvements #669

Merged
merged 41 commits into from
Apr 13, 2021

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Mar 17, 2021

Closes: #668

@jamiehewitt15 jamiehewitt15 added Status: InProgress Work in progress, don't merge Type: Documentation Improvements or additions to documentation labels Mar 17, 2021
@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review March 24, 2021 07:28
@jamiehewitt15 jamiehewitt15 removed the Status: InProgress Work in progress, don't merge label Mar 24, 2021
@kremalicious
Copy link
Contributor

not sure why Travis would run into issues for only markdown file changes. Maybe try another merge of main so we get a new build run?

Other than that this is all way better than what we have right now so let's merge it afterwards.

Copy link
Contributor

@kremalicious kremalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great detailed work!

@jamiehewitt15
Copy link
Member Author

@kremalicious Thank you

@codeclimate
Copy link

codeclimate bot commented Apr 13, 2021

Code Climate has analyzed commit 645f005 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 78.8% (0.0% change).

View more on Code Climate.

@kremalicious kremalicious merged commit 7f05b8f into main Apr 13, 2021
@kremalicious kremalicious deleted the issue-668/documentation-improvements branch April 13, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to the documentation and Quickstart flows
2 participants