Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the documentation and Quickstart flows #668

Closed
jamiehewitt15 opened this issue Mar 17, 2021 · 4 comments · Fixed by #669
Closed

Improvements to the documentation and Quickstart flows #668

jamiehewitt15 opened this issue Mar 17, 2021 · 4 comments · Fixed by #669
Assignees
Labels
Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request

Comments

@jamiehewitt15
Copy link
Member

jamiehewitt15 commented Mar 17, 2021

Prerequisites section

We should add a list of prerequisites e.g. node.js, a Unix based operating system (Mac or Linux) etc

Quickstart Section

  • I suggest we add explanations YOUR_INFURA_PROJECT_ID, metadataCacheUri, and providerUri
  • We should make sure that we provide all the terminal commands that are required to get setup initially.

Simple flow

It would be good to provide code examples that work as-is so that the user can just copy and paste them to get started, without having to edit them. This helps make the quick start even quicker and is very useful for beginners who are not familiar with the tech.

We should also add the terminal commands that are required for making new files, installing dependencies, compiling typescript, and running the files.

There are various issues with the code snippets that we should improve to make it easier for beginners:

Snippet 1:

  • await is not inside an async function
  • ocean is not defined
  • DataTokens is not defined
  • contracts is not defined
  • factoryABI is not defined
  • datatokensABI is not defined
  • web3 is not defined

Snippet 2:

Each of the environmental variables should be explained so that the user knows what values to enter where to get them from.

Snippet 4:

  • await is outside an async function

Snippet 5:

  • getInstance() expects 1 argument but there are 0
  • .download() Expected 5 arguments, but got 4.

Marketplace flow:

Snippet 1:

  • await is outside an async function
  • LogLevel is not defined

Snippet 2:

  • service1 is not defined

Snippet 3:

  • tokenAddress is not defined

Snippet 4:

  • await is outside an async function

Snippet 5:

  • price is not defined
  • assert has not been imported
@jamiehewitt15 jamiehewitt15 added Type: Enhancement New feature or request Type: Documentation Improvements or additions to documentation labels Mar 17, 2021
@trentmc trentmc changed the title Imporovements to the documentation and Quickstart flows Improvements to the documentation and Quickstart flows Mar 17, 2021
@trentmc
Copy link
Member

trentmc commented Mar 17, 2021

I like these suggestions and agree with them.

In the last several weeks, we've made many improvements to ocean.py quickstarts etc that reflect some of the goals above. Therefore ocean.py might be useful as a pattern for ocean.js.

@jamiehewitt15
Copy link
Member Author

Thanks, I've opened a draft pull request for this #669

I had a look at the ocean.py documentation and it does seem better. The "Learn More" section is a good idea, I'll add that here. The quickstart flows are also a lot more clearly explained. I notice that the ocean.py simple flow uses barge which is not used in the the ocean.js simple flow.

@trentmc
Copy link
Member

trentmc commented Mar 17, 2021

:)

ocean.py used to use rinkeby, not barge, but we recently moved it over to barge because it's simpler / faster to get going. Then the "learn more" part talks about how to link to services in more detail.

@trentmc
Copy link
Member

trentmc commented Mar 20, 2021

@jamiehewitt15 I believe you're working on this? If yes, please assign the issue to yourself, and move it to the "in progress" kanban column. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants