Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispenser creation params should not be in wei #1328

Merged

Conversation

KatunaNorbert
Copy link
Member

Fixes #1302

@codeclimate
Copy link

codeclimate bot commented Mar 9, 2022

Code Climate has analyzed commit b5587d1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.5% (0.0% change).

View more on Code Climate.

@KatunaNorbert KatunaNorbert marked this pull request as ready for review March 9, 2022 08:04
Copy link
Contributor

@kremalicious kremalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work based on the tests, ultimately can only be tested in complete flow in market

@kremalicious kremalicious merged commit bd32b95 into v4main Mar 11, 2022
@kremalicious kremalicious deleted the feature/1302-dispenser-creation-params-not-in-wei branch March 11, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispenser creation params should not be in wei
2 participants