Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispenser creation params should not be in wei #1302

Closed
mihaisc opened this issue Feb 21, 2022 · 0 comments · Fixed by #1328
Closed

Dispenser creation params should not be in wei #1302

mihaisc opened this issue Feb 21, 2022 · 0 comments · Fixed by #1328
Assignees
@KatunaNorbert
Labels
Status: Refined Type: Enhancement New feature or request
Milestone
V4

Comments

@mihaisc
Copy link
Contributor

mihaisc commented Feb 21, 2022

ocean.js/src/factories/NFTFactory.ts

Line 862 in 36fa91f

public async createNftErc20WithDispenser(

conversion in wei should happen in ocean.js like all the other functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatunaNorbert KatunaNorbert

Labels
Status: Refined Type: Enhancement New feature or request
Projects
None yet
Milestone
V4
Development

Successfully merging a pull request may close this issue.

Dispenser creation params should not be in wei oceanprotocol/ocean.js
3 participants
@mihaisc @KatunaNorbert @LoznianuAnamaria