Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] domainslib (0.4.1) #20754

Merged
merged 3 commits into from
Feb 17, 2022
Merged

[new release] domainslib (0.4.1) #20754

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19861ce
[new release] domainslib (0.4.1)
Sudha247 Feb 17, 2022
30b0bc5
works on 5.00 and later
Sudha247 Feb 17, 2022
ce6a163
domainslib.0.4.1: Fix opam syntax and add tests
kit-ty-kate Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/domainslib/domainslib.0.4.1/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
opam-version: "2.0"
maintainer: "KC Sivaramakrishnan <kc@kcsrk.info>"
authors: ["KC Sivaramakrishnan <kc@kcsrk.info>"]
homepage: "https://github.com/ocaml-multicore/domainslib"
doc: "https://ocaml-multicore.github.io/domainslib/"
synopsis: "Parallel Structures over Domains for Multicore OCaml"
license: "ISC"
dev-repo: "git+https://github.com/ocaml-multicore/domainslib.git"
bug-reports: "https://github.com/ocaml-multicore/domainslib/issues"
tags: ["org:ocamllabs"]
depends: [
"ocaml" {>= "5.00"}
"dune" {>= "1.8"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dune" {>= "1.8"}
"ocaml" {>= "5"}
"dune" {>= "1.8"}

We need to make it explicit that it is incompatible with 4.12+domains

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if "5" is the right number there though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've followed the 5.00 convention used here https://github.com/ocaml/opam-repository/blob/master/packages/base-domains/base-domains.base/opam#L7. Might probably need an update later if the version numbering were to change.

"mirage-clock-unix" {with-test}
]
build: ["dune" "build" "-p" name "-j" jobs]
run-test: ["dune" "runtest" "-p" name "-j" jobs]
url {
src: "https://github.com/ocaml-multicore/domainslib/archive/0.4.1.tar.gz"
checksum: "md5=7514b4f9c7bcc2d5c20bb1143cf0b77a"
}