[new release] domainslib (0.4.1) #20754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseri
reviewed
Feb 17, 2022
| bug-reports: "https://github.com/ocaml-multicore/domainslib/issues" | ||
| tags: ["org:ocamllabs"] | ||
| depends: [ | ||
| "dune" {>= "1.8"} |
There was a problem hiding this comment.
Suggested change
| "dune" {>= "1.8"} | |
| "ocaml" {>= "5"} | |
| "dune" {>= "1.8"} |
We need to make it explicit that it is incompatible with 4.12+domains
There was a problem hiding this comment.
Don't know if "5" is the right number there though
There was a problem hiding this comment.
Thanks! I've followed the 5.00 convention used here https://github.com/ocaml/opam-repository/blob/master/packages/base-domains/base-domains.base/opam#L7. Might probably need an update later if the version numbering were to change.
|
Thanks a lot! |
|
Could you return the fixes in the opam file upstream so that they can be taken into account for next time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release fixes compatibility with OCaml
5.00.0+trunkin ocaml-multicore/domainslib#61. Breaks compatibility with older Multicore variants4.12.0+domainsand4.12.0+domains+effects.