Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default start / stop timeout to 120 seconds (systemd) #402

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Aug 21, 2021

Description of Changes

Resolves #258

By setting TimeoutSec to two minutes, systemd will give stanza up to 120 seconds to start or stop. The value of 0 allows stanza to hang forever if there is an issue starting or stopping. This prevent servers from shutting down.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.3965454 -0.13805914 128.51495 -5.4846497
1 5000 5.2417145 +0.24169064 139.05563 +0.76805115
1 10000 10.069177 -0.43101978 147.19208 +1.8638153
1 50000 53.00142 +2.7766418 175.86746 -2.9994507
1 100000 98.59211 +4.2793655 227.31493 -3.555893
10 100 2.0345192 +0.103456855 131.01697 -1.5025635
10 500 5.7933455 -0.18953323 140.02762 -1.8997803
10 1000 11.258859 +0.4312353 147.81358 +1.2592926
10 5000 51.93199 -0.9474907 179.96956 +0.10089111
10 10000 109.083496 -0.8758545 232.62662 +0.9439697

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #402 (b02a684) into master (47e0a8b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   73.25%   73.23%   -0.01%     
==========================================
  Files         124      124              
  Lines        7999     7999              
==========================================
- Hits         5859     5858       -1     
- Misses       1639     1640       +1     
  Partials      501      501              
Impacted Files Coverage Δ
operator/builtin/input/file/file.go 79.06% <0.00%> (-1.57%) ⬇️
operator/builtin/output/forward/forward.go 64.20% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e0a8b...b02a684. Read the comment docs.

@jsirianni jsirianni merged commit e99a6e6 into master Aug 21, 2021
@jsirianni jsirianni deleted the systemd-start-stop-timeout branch August 21, 2021 01:45
@jsirianni jsirianni mentioned this pull request Aug 24, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Systemd DefaultTimeoutStopSec should be set
2 participants