Stop using MS Edge specific code for Internet Explorer edit fields. #10652
Conversation
See test results for failed build of commit 942e34cb1d |
| @@ -853,7 +853,11 @@ def findOverlayClasses(self,clsList): | |||
| # Windows 8.x toast, although a form of tool tip, is covered separately. | |||
| elif UIAControlType==UIAHandler.UIA_ToolTipControlTypeId: | |||
| clsList.append(ToolTip) | |||
| elif self.UIAElement.cachedFrameworkID in ("InternetExplorer","MicrosoftEdge"): | |||
| elif( | |||
| self.UIAElement.cachedFrameworkID in ("InternetExplorer", "MicrosoftEdge") | |||
There was a problem hiding this comment.
I'm pretty confident that Internet Explorer can be removed here, as that would only be true for the mshtml implementation, not edgeHTML. And, we would want this fix for any mshtml embedding, not just the Internet Explorer application.
There was a problem hiding this comment.
Removing InternetExplorer from there would break Edge on older builds of Windows 10 (it is used at least on 1507, 1511 and possibly Anniversary Update) as an FrameworkID. The fact that UIA is used for Internet Explorer controls on Windows 7 is however strange, because this is not occurring on Windows 10, I am not sure why.
Would it be acceptable to simply add Internet Explorer_Server to the bad UIA class names when running on anything lower than Windows 10?
|
It would be good to get this change merged into beta ASAP. @michaelDCurran can you advise if you are happy with this change based on: Does it fix the issue, and is unlikely to introduce further regressions? |
|
This is fine with the understanding that this does not fully address the issue, as mshtml controls outside of Internet Explorer may still show the bug. Not that it contains an edit field as such, but just for an example where mshtml is embedded: NVDA's formatting viewer dialog (NVDA+f twice quickly) is an embedded MSHTML control, but the appModule is NVDA, not iexplore. Out of curiosity, Do the older EdgeNodes that have a UIA className of Internet Explorer_Server have a window class of Internet Explorer_Server, or something else? If something else, then we can use the window class. |
|
In that case I'll merge this. Better to fix it in at least one situation than not at all. |
There was a problem hiding this comment.
Thanks @lukaszgo1
Would you be able to look at other situations that may not covered by this change as suggested by @michaelDCurran.
The change is beneficial to the beta, even if it does not handle all situations.
|
@feerrenrut wrote:
I'll certainly do that, however do not expect anything fast - certainly not in time for 2019.3 |
This is opened against beta.
Link to issue number:
Fixes #10613
Summary of the issue:
When support for Microsoft Edge was introduced in 2015 we started using Edge specific code for some controls in Internet Explorer. It started to be problematic when support for landmarks was introduced, as Edge specific code for landmarks was failing in IE.
Description of how this pull request fixes the issue:
The edgeNode is not used when in IE.
Testing performed:
With braille display connected:
Without this change the focus mode sound was not played, whereas now it plays.
Known issues with pull request:
None known
Change log entry:
None needed this is not in a release.