Skip to content

Commit

Permalink
Stop using MS Edge specific code for Internet Explorer edit fields. (PR
Browse files Browse the repository at this point in the history
#10652)

Fixes #10613

When support for Microsoft Edge was introduced in 2015 we started using Edge specific code for some controls in Internet Explorer. It started to be problematic when support for landmarks was introduced, as Edge specific code for landmarks was failing in IE.
  • Loading branch information
lukaszgo1 authored Jan 29, 2020
1 parent 8b190de commit 486ed0d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion source/NVDAObjects/UIA/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,11 @@ def findOverlayClasses(self,clsList):
# Windows 8.x toast, although a form of tool tip, is covered separately.
elif UIAControlType==UIAHandler.UIA_ToolTipControlTypeId:
clsList.append(ToolTip)
elif self.UIAElement.cachedFrameworkID in ("InternetExplorer","MicrosoftEdge"):
elif(
self.UIAElement.cachedFrameworkID in ("InternetExplorer", "MicrosoftEdge")
# But not for Internet Explorer
and not self.appModule.appName == 'iexplore'
):
from . import edge
if UIAClassName in ("Internet Explorer_Server","WebView") and self.role==controlTypes.ROLE_PANE:
clsList.append(edge.EdgeHTMLRootContainer)
Expand Down

0 comments on commit 486ed0d

Please sign in to comment.