-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update morpheus dev container to support flag for building with debug python build + source files. #81
Conversation
@mdemoret-nv @pdmack Please take a look when you're able. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this feature but I dont think it needs to be included in our development docker image like it currently is. This is hopefully going to be a very rarely used tool that makes more sense as a post development build stage to make it opt-in.
My comments can be summarized by:
- Add a section to
ci/conda/recipes/run_conda_build.sh
to run the recipe similar to the other recipes in that script - Make a script for installing the built conda package to clean up the Dockerfile and allow the debug python package to be installed outside of a container (for example, somewhere in
ci/conda/recipes/python-dbg
should work) - Move all of the Dockerfile changes to a post-
development
build stage.
Couldn't get this to build (based on updated CONTRIBUTING.md)
|
@pdmack That's odd, for some reason the install script isn't running in the morpheus conda environment for you, so its detecting the python version in the base environment... I'll investigate more. Not at all clear why it works on my side. Edit: I'd switched to using the wrong environment variables in the build file. Conda build defines PY_VER, but I was using PYTHON_VER, which broke some post build symbolic links. Fixed now. |
@pdmack @mdemoret-nv All the updates are in; morpheus builds without any issues in container, tests passing, etc.. should be good to go if there are no other concerns. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If @mdemoret-nv doesn't have any other change requests, I'll add a quick example of breaking within a the cpython evaluation loop and printing object contents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only one small question.
@gpucibot merge |
resolves #21
Add the ability to build the morpheus dev container with a debug build of cpython + source libraries.