forked from nv-morpheus/Morpheus
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Content Extractor Module #21
Merged
drobison00
merged 13 commits into
drobison00:devin_fea_1453_simplify_vectordb_example
from
bsuryadevara:bhargav_fea_1453_simplify_vectordb_example
Jan 10, 2024
Merged
Updated Content Extractor Module #21
drobison00
merged 13 commits into
drobison00:devin_fea_1453_simplify_vectordb_example
from
bsuryadevara:bhargav_fea_1453_simplify_vectordb_example
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsuryadevara
commented
Jan 10, 2024
- Added Haystack Converter API to convert CSV, PDF, DOCX to text.
drobison00
reviewed
Jan 10, 2024
def read_pdf_file(file): | ||
outgoing_edges = 1 | ||
|
||
def convert(self, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
def convert(self, | |
def convert_csv_to_document(self, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert
function is an abstractmethod of Haystack BaseConverter API
Co-authored-by: Devin Robison <drobison00@users.noreply.github.com>
Co-authored-by: Devin Robison <drobison00@users.noreply.github.com>
Co-authored-by: Devin Robison <drobison00@users.noreply.github.com>
…:drobison00/devin-morpheus-public into bhargav_fea_1453_simplify_vectordb_example
…om:bsuryadevara/Morpheus into bhargav_fea_1453_simplify_vectordb_example
c20b4a5
into
drobison00:devin_fea_1453_simplify_vectordb_example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.