Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify_init decorator in DFPArgParser #1152

Closed

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Aug 24, 2023

Description

  • Revert updates to verify_init decorator and move to inner class to avoid pylint errors.
  • Revert updates to dfp benchmark pytest hook and disable unused-argument pylint error.

Fixes #1151
Fixes #1153

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Aug 24, 2023
@efajardo-nv efajardo-nv marked this pull request as ready for review August 24, 2023 19:34
@efajardo-nv efajardo-nv requested a review from a team as a code owner August 24, 2023 19:34
@efajardo-nv efajardo-nv self-assigned this Aug 25, 2023
@mdemoret-nv
Copy link
Contributor

Lets close this in favor of the other related PR

@efajardo-nv
Copy link
Contributor Author

Closing this. Fixes already in #1154.

@efajardo-nv efajardo-nv deleted the dfp-arg-parser-fix branch July 29, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
2 participants