Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: DFPArgParser error when running module-based DFP pipeline #1151

Closed
2 tasks done
efajardo-nv opened this issue Aug 24, 2023 · 0 comments · Fixed by #1154
Closed
2 tasks done

[BUG]: DFPArgParser error when running module-based DFP pipeline #1151

efajardo-nv opened this issue Aug 24, 2023 · 0 comments · Fixed by #1154
Assignees
Labels
bug Something isn't working

Comments

@efajardo-nv
Copy link
Contributor

efajardo-nv commented Aug 24, 2023

Version

23.11

Which installation method(s) does this occur on?

Docker

Describe the bug.

Ran into error running module-based DFP pipeline. Appears to be caused by recent updates to DFPArgParser by PR #1082.

Minimum reproducible example

Run module-based Duo training DFP pipeline in DFP container:

python /workspace/examples/digital_fingerprinting/production/morpheus/dfp_integrated_training_batch_pipeline.py     --use_cpp=true     --source duo     --start_time "2022-08-01"     --duration "60d"     --train_users generic     --log_level DEBUG     --input_file "/workspace/examples/digital_fingerprinting/production/morpheus/benchmarks/resource/control_messages/duo_payload_training.json"

Relevant log output

Traceback (most recent call last):
  File "/workspace/examples/digital_fingerprinting/production/morpheus/dfp_integrated_training_batch_pipeline.py", line 23, in <module>
    from dfp.utils.config_generator import ConfigGenerator
  File "/workspace/examples/digital_fingerprinting/production/morpheus/dfp/utils/config_generator.py", line 17, in <module>
    from dfp.utils.dfp_arg_parser import DFPArgParser
  File "/workspace/examples/digital_fingerprinting/production/morpheus/dfp/utils/dfp_arg_parser.py", line 36, in <module>
    class DFPArgParser:
  File "/workspace/examples/digital_fingerprinting/production/morpheus/dfp/utils/dfp_arg_parser.py", line 87, in DFPArgParser
    def time_fields(self):
TypeError: DFPArgParser.verify_init() missing 1 required positional argument: 'func'

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@efajardo-nv efajardo-nv added the bug Something isn't working label Aug 24, 2023
@efajardo-nv efajardo-nv self-assigned this Aug 24, 2023
@efajardo-nv efajardo-nv added this to the 23.11 - DFP Improvements milestone Aug 28, 2023
@rapids-bot rapids-bot bot closed this as completed in #1154 Sep 1, 2023
rapids-bot bot pushed a commit that referenced this issue Sep 1, 2023
- Update docs to include command line examples of running module-based DFP pipelines (training, inference, training+inference)
- Move control messages to centralized location for use with running examples and benchmarks
- Rename run scripts to be more generic

Closes #1147
Fixes #1151
Fixes #1153

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1154
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
1 participant