-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix load_module bug with unserializable objects #462
Fix load_module bug with unserializable objects #462
Conversation
…tores previous behavior prior to PR nv-morpheus#451
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-24.03 #462 +/- ##
=============================================
Coverage 73.68% 73.68%
=============================================
Files 400 400
Lines 14275 14286 +11
Branches 1113 1115 +2
=============================================
+ Hits 10518 10527 +9
- Misses 3757 3759 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Closing this PR in favor of fixing the issue on the Morpheus side, serializing to a json null simply hid a bug in Morpheus. |
Description
cast_from_pyobject
behavior to throw an exception rather than returning a null.dfp_integrated_training_batch_pipeline.py
which storeddatetime
objects in the module config.unserializable_handler_fn
functionality from 24.06, and adds a handler toModuleRegistryProxy::get_module_constructor
andBuilderProxy::load_module_from_registry
to restore the original functionality as a quick-fix for 24.03Checklist