Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Recent changes to cast_from_pyobject broke load_module_from_registry #461

Closed
2 tasks done
dagardner-nv opened this issue Apr 4, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.03

Which installation method(s) does this occur on?

Source

Describe the bug.

PR #451 appears to have broken BuilderProxy::load_module_from_registry when an unserializable object is passed in with the config.

I haven't reproduced this in MRC yet, but in Morpheus the dfp_integrated_training_batch_pipeline.py will pass in a datetime object in the config. In recent versions of MRC this now throws, not sure how it was handled prior to this.

Minimum reproducible example

No response

Relevant log output

No response

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow MRC's Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Apr 4, 2024
@dagardner-nv dagardner-nv self-assigned this Apr 4, 2024
dagardner-nv added a commit to dagardner-nv/MRC that referenced this issue Apr 4, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Apr 4, 2024
@dagardner-nv
Copy link
Contributor Author

The issue is that prior to PR #451 cast_from_pyobject would return a json null value for unserializable values, now it throws.

@dagardner-nv
Copy link
Contributor Author

Closing this in favor of fixing on the Morpheus side.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Morpheus Boards Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant