Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons for JetBrains AppCode #5437

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Icons for JetBrains AppCode #5437

merged 3 commits into from
Jul 2, 2020

Conversation

maxtron95
Copy link
Contributor

@maxtron95 maxtron95 requested review from Foggalong and palob as code owners July 1, 2020 23:10
@palob palob added the merge label Jul 2, 2020
palob
palob approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@palob palob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you've already done the work there's nothing wrong with this compared to the other jetbrains icons in Circle but there's issue #3706 which stopped the conversion of Square icons to the new style.

@Foggalong Foggalong changed the base branch from master to jetbrains July 2, 2020 11:16
@Foggalong
Copy link
Contributor

I'm approving this to be merged into a JetBrains working branch where I'm going to handle the above issue about the redesign :)

@Foggalong Foggalong merged commit bc0cb2c into numixproject:jetbrains Jul 2, 2020
@Foggalong Foggalong mentioned this pull request Jul 2, 2020
Open
22 tasks
@maxtron95 maxtron95 deleted the appcode branch August 18, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foggalong Foggalong Foggalong approved these changes

@palob palob palob approved these changes

Assignees
No one assigned
Labels
merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxtron95 @Foggalong @palob