-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetbrains icons look out of place #3706
Comments
When we merged those we intentionally opted for a 2-colour-gradient as there was no single characteristic colur in the oiginal icons. There are a few more icons with a 2-colour gradient, for instance curlew and soundnode. |
Ideally I would like to get rid of dual gradients in all icons, so I'm gonna leave this open. If anyone does have any good ideas how to make this happen so that it works across all the dual gradient icons I'd love to hear them. @MrTimscampi I'd be interested to know if the averaging works for all the Jetbrains ones |
@Foggalong I haven't tested all of them, but PyCharm and IntelliJ work pretty well. Stuff that has wildly different colors might be less perfect, though. I'm busy until early July with finals and internship/thesis presentations, but I'll try to make a few of them if/when I have time, if you want. |
@MrTimscampi There haven't been any guideline changes that I'm aware of? But anyways submit a PR and we'll see what we can do about the jarring ones :) |
@MrTimscampi Are you still submitting a PR with these changes? |
I've created svg icons for PyCharm and IntelliJ IDEA: idea and pycharm icons.zip This is what they look like in Unity: Font used is Ubuntu Mono. |
They look cool but this would make them stand out even more. |
@palob True. I used a Numix Square icon as a base.. Maybe it would be possible to modify them to fit in better. Whoever wants to modify them to fit in and push the work to one of Numix repositories, feel free. |
As @palob mentioned in #4157 , this is blocking adoption of Jetbrains new rebranding (to all 2-letter icons). The multicolor background is part of Jetbrains branding and is recognizable. I think for that reason the multicolor background should stay. @palob basically mentioned this early in the thread and others seemed to agree. |
@bkanuka If the concern is that it contradicts branding, then it's a moot point. The whole idea of universal icon themes are to override the design decisions of each app developer and standardise to a consistent design theme. Whether or not you agree with that is a topic of debate (Sam Hewitt of Moka & Suru fame did a great blog on the topic. Personally disagree with his points, but it's worth a read nonetheless) but if you're using a universal icon theme then there's the implicit assumption that that's what it'll do. |
@Foggalong you make a good point. Really though I'm less concerned with numix contradicting branding, than I am with it contradicting itself. Currently jetbrains icons are different between square and circle variants (the circle icons all use 2-letter style). Among the square icons, some jetbrains icons use 2-letter style, and others use an older icon style. A decision needs to be made here before jetbrains icons can be made consistent throughout (see #4157). I have an opinion, as stated above, but that's secondary ;-) |
@bkanuka Oh don't worry about that - there's a series of fixes currently in the works to standardise the styles across Circle & Square. The distinctions now are just a holdout from the theme having not been updated for a while 😄 |
Did those apps' icons stop to be hardcoded? From #4198 it seems the icon names are simply |
Are we ready for a decision? @janoj You are the one who did the redesign. Do you remember which font you used or did you come up with the paths from scratch? |
Yeah what was said here still stands. I'd like to move to move away from two tone gradients where possible :) |
@MrTimscampi Would you still be up for submitting a PR to solve this or do you want us to handle it? |
@Foggalong I don't really use Numix or Jetbrains software anymore, so feel free to handle it :) |
@MrTimscampi Sure thing 👍 |
One more thing to do:
|
The redisigned Jetbrains icons have a wild gradient that goes way out of the 10L guideline.
AFAIK, they're the only icons to do that and, as a result, look quite out of place.
I suggest averaging the two colors of the current gradient and then applying a 10L gradient as usual.
Examples:
=> 
The text was updated successfully, but these errors were encountered: