Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Add endpoint for requesting execution with an execution token #90

Merged
merged 10 commits into from
Jun 8, 2021
Merged

Add endpoint for requesting execution with an execution token #90

merged 10 commits into from
Jun 8, 2021

Conversation

longtomjr
Copy link
Collaborator

@longtomjr longtomjr commented Jun 7, 2021 •
edited by PiDelport
Loading

Issue: #71

@longtomjr longtomjr added feat New feature or request M: web service Module: Web API service (rtc_data_service) labels Jun 7, 2021
@longtomjr longtomjr self-assigned this Jun 7, 2021
@longtomjr longtomjr marked this pull request as ready for review June 8, 2021 07:53
@PiDelport PiDelport force-pushed the he-request-execution-api branch from 27f730a to b2b4014 Compare June 8, 2021 09:19
@PiDelport
Copy link
Collaborator

(Rebased to refresh)

PiDelport
PiDelport approved these changes Jun 8, 2021
View reviewed changes
Copy link
Collaborator

@PiDelport PiDelport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

I added a quick test to exercise the endpoint, and few more changes just to make that run and pass.

This was referenced Jun 8, 2021
Merged
Open
@longtomjr
Copy link
Collaborator Author

Looks good! sparkles

I added a quick test to exercise the endpoint, and few more changes just to make that run and pass.

Thanks for the changes!

@longtomjr longtomjr merged commit 1b277a3 into main Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PiDelport PiDelport PiDelport approved these changes

@Nghondzweni Nghondzweni Awaiting requested review from Nghondzweni

Assignees

@longtomjr longtomjr

Labels
feat New feature or request M: web service Module: Web API service (rtc_data_service)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longtomjr @PiDelport