Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nsubstitute 4.4 api #187

Merged
merged 10 commits into from
Aug 13, 2022
Merged

Support for nsubstitute 4.4 api #187

merged 10 commits into from
Aug 13, 2022

Conversation

tpodolak
Copy link
Member

  • detects non-virtual calls for ThrowsAsync/ThrowsAsyncForAnyArgs
  • offers code fix for changing Throws /ThrowsForAnyArgsto ThrowsAsync/ThrowsAsyncForAnyArgs
    ThrowsAsync

closes #186

@tpodolak tpodolak force-pushed the GH-186-support-nsubstitute-4.4 branch from 41f8c0a to ad97761 Compare July 22, 2022 14:54
@tpodolak tpodolak marked this pull request as draft July 22, 2022 15:06
@tpodolak tpodolak marked this pull request as ready for review July 22, 2022 16:02
@tpodolak tpodolak force-pushed the GH-186-support-nsubstitute-4.4 branch 2 times, most recently from 8e773dd to 95d877f Compare July 22, 2022 18:02
@tpodolak
Copy link
Member Author

It looks like we are not able to push coverage reports to coveralls.io anymore. Every time we try to do it, we get BadRequest.

dotnet-cake.exe : Failed to upload to coveralls
At C:\projects\nsubstitute-analyzers\build\build.ps1:84 char:5
+     & "$CakeExePath" ./build.cake $args
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Failed to upload to coveralls:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
BadRequest - <html>
<head><title>400 Bad Request</title></head>
<body>
<center><h1>400 Bad Request</h1></center>
<hr><center>nginx</center>
</body>
</html>
An error occurred when executing task 'Upload-Coverage-Report'.

Unfortunately response does not have any details about what exactly is wrong. I thought that this might be related with this particular branch, however it also fails for other branches e.g
#188 (build log https://ci.appveyor.com/project/NSubstitute/nsubstitute-analyzers/builds/44254605/job/qnc295pwjuwmd1i0)
@nsubstitute/core-contributors any thoughts what should we do in here? Did anyone encounter this kind of issue before?

dtchepak
dtchepak approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@dtchepak dtchepak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your hard work, @tpodolak !

@tpodolak tpodolak mentioned this pull request Aug 12, 2022
Closed
@tpodolak tpodolak force-pushed the GH-186-support-nsubstitute-4.4 branch from fe98b94 to 36da47b Compare August 12, 2022 23:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 493

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 93.609%
Files with Coverage Reduction New Missed Lines %
C/projects/nsubstitute-analyzers/src/NSubstitute.Analyzers.Shared/Extensions/SubstituteSymbolExtensions.cs 1 96.67%
Totals Coverage Status
Change from base Build 477: 0.1%
Covered Lines: 2739
Relevant Lines: 2926
💛 - Coveralls

@tpodolak tpodolak merged commit 6053d65 into dev Aug 13, 2022
@tpodolak tpodolak deleted the GH-186-support-nsubstitute-4.4 branch August 13, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtchepak dtchepak dtchepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for NSubstitute 4.4 api
3 participants
@tpodolak @coveralls @dtchepak