GH-186 - manually 'skipping' ThrowsAsync like tests cases for literal…

… expressions
nsubstitute · Jul 22, 2022 · 95d877f · 95d877f
1 parent a1c04c6
commit 95d877f
Show file tree

Hide file tree

Showing 7 changed files with 57 additions and 0 deletions.
diff --git a/...agnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs b/...agnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs
@@ -41,6 +41,14 @@ public void Test()
 
     public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type)
     {
+        if (method.Contains("Async"))
+        {
+            // ThrowsAsync like methods do not extend literals
+            // TODO replace with Assert.Skip once xUnit v3 released
+            // https://github.com/xunit/xunit/issues/2073
+            return;
+        }
+
         var source = $@"using System;
 using NSubstitute;
 using NSubstitute.ExceptionExtensions;

diff --git a/...nSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodWithGenericTypeSpecifiedTests.cs b/...nSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodWithGenericTypeSpecifiedTests.cs
@@ -41,6 +41,14 @@ public void Test()
 
     public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type)
     {
+        if (method.Contains("Async"))
+        {
+            // ThrowsAsync like methods do not extend literals
+            // TODO replace with Assert.Skip once xUnit v3 released
+            // https://github.com/xunit/xunit/issues/2073
+            return;
+        }
+
         var source = $@"using System;
 using NSubstitute;
 using NSubstitute.ExceptionExtensions;

diff --git a/...iagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs b/...iagnosticAnalyzerTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs
@@ -46,6 +46,14 @@ public void Test()
 
     public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type)
     {
+        if (method.Contains("Async"))
+        {
+            // ThrowsAsync like methods do not extend literals
+            // TODO replace with Assert.Skip once xUnit v3 released
+            // https://github.com/xunit/xunit/issues/2073
+            return;
+        }
+
         var source = $@"using System;
 using NSubstitute;
 using NSubstitute.ExceptionExtensions;

diff --git a/...onSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs b/...onSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs
@@ -45,6 +45,14 @@ public void Test()
 
     public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type)
     {
+        if (method.Contains("Async"))
+        {
+            // ThrowsAsync like methods do not extend literals
+            // TODO replace with Assert.Skip once xUnit v3 released
+            // https://github.com/xunit/xunit/issues/2073
+            return;
+        }
+
         var source = $@"using System;
 using NSubstitute;
 using NSubstitute.ExceptionExtensions;

diff --git a/...gnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs b/...gnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsExtensionMethodTests.cs
@@ -4,6 +4,7 @@
 using NSubstitute.Analyzers.Shared.Settings;
 using NSubstitute.Analyzers.Tests.Shared.Extensibility;
 using NSubstitute.Analyzers.Tests.Shared.Extensions;
+using Xunit;
 
 namespace NSubstitute.Analyzers.Tests.VisualBasic.DiagnosticAnalyzersTests.NonSubstitutableMemberAnalyzerTests;
 
@@ -39,6 +40,14 @@ End Namespace
 
     public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type)
     {
+        if (method.Contains("Async"))
+        {
+            // ThrowsAsync like methods do not extend literals
+            // TODO replace with Assert.Skip once xUnit v3 released
+            // https://github.com/xunit/xunit/issues/2073
+            return;
+        }
+
         var source = $@"Imports System
 Imports NSubstitute
 Imports NSubstitute.ExceptionExtensions

diff --git a/...agnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs b/...agnosticAnalyzersTests/NonSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodTests.cs
@@ -44,6 +44,14 @@ End Namespace
 
     public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type)
     {
+        if (method.Contains("Async"))
+        {
+            // ThrowsAsync like methods do not extend literals
+            // TODO replace with Assert.Skip once xUnit v3 released
+            // https://github.com/xunit/xunit/issues/2073
+            return;
+        }
+
         var source = $@"Imports System
 Imports NSubstitute
 Imports NSubstitute.ExceptionExtensions

diff --git a/...onSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs b/...onSubstitutableMemberAnalyzerTests/ThrowsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs
@@ -43,6 +43,14 @@ End Namespace
 
     public override async Task ReportsDiagnostics_WhenSettingValueForLiteral(string method, string literal, string type)
     {
+        if (method.Contains("Async"))
+        {
+            // ThrowsAsync like methods do not extend literals
+            // TODO replace with Assert.Skip once xUnit v3 released
+            // https://github.com/xunit/xunit/issues/2073
+            return;
+        }
+
         var source = $@"Imports System
 Imports NSubstitute
 Imports NSubstitute.ExceptionExtensions