Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move authmate to neofs-s3-gw #52

Merged

Conversation

masterSplinter01
Copy link
Contributor

@masterSplinter01 masterSplinter01 commented May 19, 2021

Closes #46

Moved authmate repository to neofs-s3-gw.

Renamed the package s3 and the file s3.go from authmate-repo to "authmate" to authmate.go.

Created new folders and placed source files this way:

  1. authmate/authmate.go
  2. cmd/authmate/main.go

Added building of bins to Makefile. Now bin file has name 'neofs-authmate'.

Binary files of neofs-authmate was not added to dockerfile/docker image etc.

Copy authmate main file and s3 agent

Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can just squash 137e690 and dae6936. Otherwise it's a bit noisy here, though other commits are nice.

Have you tried make lint on it?

And is it literally [nspcc-dev#46] in commit headings? Maybe [#46] is enough?

@masterSplinter01 masterSplinter01 force-pushed the 46-move-authmate-to-neofs-s3-gw branch from f02cd7c to ce9cb97 Compare May 19, 2021 12:28
Fix variables for docker, sorted variables' blocks
Rename binary from authmate to neofs-authmate

Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
@masterSplinter01
Copy link
Contributor Author

Sorry, squashed noisy commits.

@roman-khimov
Copy link
Member

And is it literally [#46] in commit headings? Maybe [#46] is enough?

As I've suspected it's GitHub playing its autoreplace tricks, NM.

@roman-khimov
Copy link
Member

Please fix linters and it'd be good to merge:

authmate/authmate.go:186:72  godot     Comment should end in a period
cmd/authmate/main.go:35:20   godot     Comment should end in a period
authmate/authmate.go:30:6    golint    exported type `Agent` should have comment or be unexported
authmate/authmate.go:35:1    golint    exported function `New` should have comment or be unexported
authmate/authmate.go:40:2    golint    exported type `IssueSecretOptions` should have comment or be unexported
authmate/authmate.go:49:2    golint    exported type `ObtainSecretOptions` should have comment or be unexported
authmate/authmate.go:91:1    golint    exported method `Agent.IssueSecret` should have comment or be unexported
authmate/authmate.go:141:1   golint    exported method `Agent.ObtainSecret` should have comment or be unexported
cmd/authmate/main.go:130:33  gosimple  S1019: should use make([]hcs.Credentials, count) instead
cmd/authmate/main.go:166:33  gosimple  S1019: should use make([]gateKey, len(csl)) instead
make: *** [Makefile:95: lint] Ошибка 1

@roman-khimov roman-khimov added this to the v0.15.0 milestone May 19, 2021
@masterSplinter01
Copy link
Contributor Author

masterSplinter01 commented May 19, 2021

Added new changes via linter messages. Could you please check them, especially new comments?

@masterSplinter01 masterSplinter01 force-pushed the 46-move-authmate-to-neofs-s3-gw branch 2 times, most recently from f872dce to 1f716fb Compare May 19, 2021 16:17
… creations

Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
@masterSplinter01 masterSplinter01 force-pushed the 46-move-authmate-to-neofs-s3-gw branch from 1f716fb to 4e06ee3 Compare May 19, 2021 16:27
@roman-khimov roman-khimov merged commit bbd1afd into nspcc-dev:master May 19, 2021
@masterSplinter01 masterSplinter01 deleted the 46-move-authmate-to-neofs-s3-gw branch July 16, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move authmate into neofs-s3-gate repo
2 participants