-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move authmate to neofs-s3-gw #52
Merged
roman-khimov
merged 8 commits into
nspcc-dev:master
from
masterSplinter01:46-move-authmate-to-neofs-s3-gw
May 19, 2021
Merged
Move authmate to neofs-s3-gw #52
roman-khimov
merged 8 commits into
nspcc-dev:master
from
masterSplinter01:46-move-authmate-to-neofs-s3-gw
May 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy authmate main file and s3 agent Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f02cd7c
to
ce9cb97
Compare
Fix variables for docker, sorted variables' blocks Rename binary from authmate to neofs-authmate Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Sorry, squashed noisy commits. |
Please fix linters and it'd be good to merge:
|
Added new changes via linter messages. Could you please check them, especially new comments? |
f872dce
to
1f716fb
Compare
… creations Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
1f716fb
to
4e06ee3
Compare
roman-khimov
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46
Moved authmate repository to neofs-s3-gw.
Renamed the package s3 and the file s3.go from authmate-repo to "authmate" to authmate.go.
Created new folders and placed source files this way:
Added building of bins to Makefile. Now bin file has name 'neofs-authmate'.
Binary files of neofs-authmate was not added to dockerfile/docker image etc.