[#149] Removed grpc errors #151
Closed
+7
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
we should check that filename header wasn't set, otherwise we should not change custom filename Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
API Handlers
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Could not find how to use it. I propose open issue and describe how to use it and then implement method. Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
DeleteObject should remove all objects with passed nice name Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Pavel Korotkov <pkorotkov@gmail.com>
Signed-off-by: Pavel Korotkov <pkorotkov@gmail.com>
Docs/24 add aws s3 compat list
API Handlers (DeleteObject handler)
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
- should receive error instead custom type - change visibility of WriteResponse method Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
should receive base error type instead of custom errors Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
method should return gRPC status error Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
- methods should return api.DeleteErrors - DeleteObjects should return only slice of errors - don't add nil errors Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
- methods should return api.DeleteErrors - DeleteObjects should return only slice of errors - don't add nil errors Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
method should returns gRPC status errors Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
closes #26 Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
closes #28 Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>
Supported x-amz-copy-source-if-match and x-amz-copy-source-if-none-match. Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
[#95] Supported get match headers
[#129] Fix root objects listing
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
…ing-for-benchmark null-versioning and corresponding handler
[#133] Fix response time format
[#135] Add max-keys check to ListObjects
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Update sdk-go and api-go versions
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Update api-go and sdk-go versions
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Bucket should has unique name. Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Container must be public (basic acl) to enable bearer token. Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Fixed contentType attribute difference in expected and actual results Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
…ed_methods [#142] Updated list of supported methods
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Because ListObjects v1 and v2 shouldn't show metadata. Also aws cli doesn't show metadata even we return it. Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Fix util tests
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
…ique [#125] Fixed bucket creation
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #149
Signed-off-by: Denis Kirillov denis@nspcc.ru