[#125] Fixed bucket creation #143
Conversation
Bucket should has unique name. Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Container must be public (basic acl) to enable bearer token. Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
api/layer/layer.go
Outdated
| if err != nil { | ||
| errMsg := err.Error() | ||
| if strings.Contains(errMsg, "bucket not found") || | ||
| strings.Contains(errMsg, "container not found") { |
There was a problem hiding this comment.
Can we do better here?
I think GetBucketInfo function can return one predefined error if bucket was not found and we can use errors.Is on that. I also see, that GetBucketInfo returns grpc related status error, which doesn't make sense to me. Maybe I am missing something.
There was a problem hiding this comment.
I suppose grpc related status is used to form more precisely http response status in HeadBucketHandler.
There was a problem hiding this comment.
Yeah. But gRPC status codes are not directly related to HTTP status codes.
Probably the usage of gRPC statuses was inspired by NeoFS transport layer (it uses gRPC). However NeoFS does not define single transport library and not limited to gRPC. In fact NeoFS API Client tries to hide transport layer details.
I think we should not use gRPC statuses. This repository should define consistent way how it transform API errors into S3 related HTTP errors, that's it. I propose to discuss it in #149.
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
closes #125
Signed-off-by: Denis Kirillov denis@nspcc.ru