cmd: disable zap log sampling #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 23.38% 23.40% +0.01%
==========================================
Files 20 20
Lines 4781 4782 +1
==========================================
+ Hits 1118 1119 +1
Misses 3504 3504
Partials 159 159 ☔ View full report in Codecov by Sentry. |
carpawell
approved these changes
Nov 13, 2024
Skipping log lines is not safe to be used by default. See also: * nspcc-dev/neofs-node#3011 * nspcc-dev/neo-go#598 Signed-off-by: Roman Khimov <roman@nspcc.ru>
3596ccf to
2bb64f7
Compare
cthulhu-rider
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping log lines is not safe to be used by default. Notice that s3-authmate doesn't have this problem because of the way it constructs its settings.
See also: