Logging fixes #598
Merged
Logging fixes #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-kulikov
approved these changes
Jan 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 63.32% 63.32%
=======================================
Files 122 122
Lines 10074 10074
=======================================
Hits 6379 6379
Misses 3399 3399
Partials 296 296
Continue to review full report at Codecov.
|
It's not safe, we don't want to lose messages and we don't have that many of them to try to figure out what is the better value than the default 100.
Makes no sense polluting logs with Info. It also affects benchmarking.
It doesn't make sense trying to read from a broken connection and the disconnect is to be logger from the server on unregistration.
8118a7b to
2192b66
Compare
volekerb
approved these changes
Jan 13, 2020
roman-khimov
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 13, 2024
The default Zap config is: > Sampling is enabled at 100:100 by default, meaning that after the first 100 log entries with the same level and message in the same second, it will log every 100th entry with the same level and message in the same second. You may disable this behavior by setting Sampling to nil. It leads to message loss too easily and we care a lot about each and every object. Notice that it was disabled in NeoGo as well in a52e016c22de2269fcc7362f33317cebfa7e8e4c (nspcc-dev/neo-go#598). Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 13, 2024
The default Zap config is: > Sampling is enabled at 100:100 by default, meaning that after the first 100 log entries with the same level and message in the same second, it will log every 100th entry with the same level and message in the same second. You may disable this behavior by setting Sampling to nil. It leads to message loss too easily and we care a lot about each and every object. Notice that it was disabled in NeoGo as well in a52e016c22de2269fcc7362f33317cebfa7e8e4c (nspcc-dev/neo-go#598). Signed-off-by: Roman Khimov <roman@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 13, 2024
The default Zap config is: > Sampling is enabled at 100:100 by default, meaning that after the first 100 log entries with the same level and message in the same second, it will log every 100th entry with the same level and message in the same second. You may disable this behavior by setting Sampling to nil. It leads to message loss too easily and we care a lot about each and every object. Notice that it was disabled in NeoGo as well in a52e016c22de2269fcc7362f33317cebfa7e8e4c (nspcc-dev/neo-go#598).
carpawell
pushed a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Nov 13, 2024
The default Zap config is: > Sampling is enabled at 100:100 by default, meaning that after the first 100 log entries with the same level and message in the same second, it will log every 100th entry with the same level and message in the same second. You may disable this behavior by setting Sampling to nil. It leads to message loss too easily and we care a lot about each and every object. Notice that it was disabled in NeoGo as well in a52e016c22de2269fcc7362f33317cebfa7e8e4c (nspcc-dev/neo-go#598). Signed-off-by: Roman Khimov <roman@nspcc.ru> (cherry picked from commit 0ffbfc1) Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
roman-khimov
added a commit
to nspcc-dev/neofs-s3-gw
that referenced
this pull request
Nov 13, 2024
Skipping log lines is not safe to be used by default. Notice that s3-authmate doesn't have this problem because of the way it constructs its settings. See also: * nspcc-dev/neofs-node#3011 * nspcc-dev/neo-go#598 Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
to nspcc-dev/neo-exporter
that referenced
this pull request
Nov 13, 2024
Skipping log lines is not safe to be used by default. Notice that s3-authmate doesn't have this problem because of the way it constructs its settings. See also: * nspcc-dev/neofs-node#3011 * nspcc-dev/neo-go#598 Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
to nspcc-dev/neofs-oauthz
that referenced
this pull request
Nov 13, 2024
Skipping log lines is not safe to be used by default. Notice that s3-authmate doesn't have this problem because of the way it constructs its settings. See also: * nspcc-dev/neofs-node#3011 * nspcc-dev/neo-go#598 Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
to nspcc-dev/neofs-rest-gw
that referenced
this pull request
Nov 13, 2024
Skipping log lines is not safe to be used by default. Notice that s3-authmate doesn't have this problem because of the way it constructs its settings. See also: * nspcc-dev/neofs-node#3011 * nspcc-dev/neo-go#598 Signed-off-by: Roman Khimov <roman@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-oauthz
that referenced
this pull request
Nov 13, 2024
Skipping log lines is not safe to be used by default. Notice that s3-authmate doesn't have this problem because of the way it constructs its settings. See also: * nspcc-dev/neofs-node#3011 * nspcc-dev/neo-go#598
roman-khimov
added a commit
to nspcc-dev/neofs-rest-gw
that referenced
this pull request
Nov 13, 2024
Skipping log lines is not safe to be used by default. See also: * nspcc-dev/neofs-node#3011 * nspcc-dev/neo-go#598 Signed-off-by: Roman Khimov <roman@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tune logs for benchmarking and fix some things. Related to #284.