Return the composite error of PUT operation #813

cthulhu-rider · 2021-09-08T23:15:48Z

Closes #778.

…eration In previous implementation Object service's handler returned const error in case of failure (full or partial) of PUT operation. This did not even allow us to roughly guess what the reason is. Not as a complete solution, but to alleviate some cases where all nodes in a container return the same error, it is suggested to return the error of the last server that responded. Return latest server error from placement loop of `iteratePlacement` method of `distributedTarget` type. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

codecov · 2021-09-08T23:17:56Z

Codecov Report

Merging #813 (9c3d524) into master (7405155) will decrease coverage by 0.47%.
The diff coverage is 9.78%.

❗ Current head 9c3d524 differs from pull request most recent head 00fd947. Consider uploading reports for the commit 00fd947 to get more accurate results

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   40.17%   39.69%   -0.48%     
==========================================
  Files         225      230       +5     
  Lines       11048    11228     +180     
==========================================
+ Hits         4438     4457      +19     
- Misses       6256     6416     +160     
- Partials      354      355       +1

Impacted Files	Coverage Δ
pkg/innerring/processors/governance/processor.go	`0.00% <0.00%> (ø)`
pkg/innerring/processors/netmap/processor.go	`0.00% <0.00%> (ø)`
pkg/morph/event/container/delete_notary.go	`0.00% <0.00%> (ø)`
pkg/morph/event/container/eacl.go	`70.96% <0.00%> (-5.70%)`	⬇️
pkg/morph/event/container/eacl_notary.go	`0.00% <0.00%> (ø)`
pkg/morph/event/container/put_notary.go	`0.00% <0.00%> (ø)`
pkg/morph/event/container/delete.go	`54.16% <50.00%> (-6.71%)`	⬇️
pkg/services/object/acl/acl.go	`2.76% <100.00%> (+0.74%)`	⬆️
pkg/services/object/acl/eacl/validator.go	`13.69% <100.00%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7405155...00fd947. Read the comment docs.

pkg/services/object/put/distributed.go

…ompletePut Make `errIncompletePut` to be a structure which wraps single client error. Wrap error of the last client into `errIncompletePut` during placement execution. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider added the neofs-storage Storage node application issues label Sep 8, 2021

cthulhu-rider self-assigned this Sep 8, 2021

cthulhu-rider requested review from alexvanin and carpawell September 10, 2021 10:19

alexvanin approved these changes Sep 10, 2021

View reviewed changes

pkg/services/object/put/distributed.go Outdated Show resolved Hide resolved

alexvanin approved these changes Sep 10, 2021

View reviewed changes

alexvanin merged commit 61b4baf into nspcc-dev:master Sep 10, 2021

cthulhu-rider deleted the 778-object-put-multierr branch September 30, 2022 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return the composite error of PUT operation #813

Return the composite error of PUT operation #813

cthulhu-rider commented Sep 8, 2021

codecov bot commented Sep 8, 2021 •

edited

Loading

Return the composite error of PUT operation #813

Return the composite error of PUT operation #813

Conversation

cthulhu-rider commented Sep 8, 2021

codecov bot commented Sep 8, 2021 • edited Loading

Codecov Report

codecov bot commented Sep 8, 2021 •

edited

Loading