Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand incomplete object put error #778

Closed
alexvanin opened this issue Aug 29, 2021 · 0 comments · Fixed by #813
Closed

Expand incomplete object put error #778

alexvanin opened this issue Aug 29, 2021 · 0 comments · Fixed by #813
Assignees
@cthulhu-rider
Labels
neofs-storage Storage node application issues

Comments

@alexvanin
Copy link
Contributor

If all container nodes refuse to store the object, node throws incomplete object put error. While we are lacking of proper error handling, wrapping latest error message in the chain of put request is better than doing absolutely nothing.
@cthulhu-rider cthulhu-rider self-assigned this Sep 8, 2021
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Sep 8, 2021
[nspcc-dev#778] services/object: Return the composite error of PUT op…
b920101 
…eration

In previous implementation Object service's handler returned const error in
case of failure (full or partial) of PUT operation. This did not even allow
us to roughly guess what the reason is. Not as a complete solution, but to
alleviate some cases where all nodes in a container return the same error,
it is suggested to return the error of the last server that responded.

Return latest server error from placement loop of `iteratePlacement` method
of `distributedTarget` type.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider mentioned this issue Sep 8, 2021
Merged
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Sep 10, 2021
[nspcc-dev#778] services/object: Wrap last client's error into errInc…
00fd947 
…ompletePut

Make `errIncompletePut` to be a structure which wraps single client error.
Wrap error of the last client into `errIncompletePut` during placement
execution.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@alexvanin alexvanin mentioned this issue Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
neofs-storage Storage node application issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return the composite error of PUT operation cthulhu-rider/neofs-node
2 participants
@alexvanin @cthulhu-rider