Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion bug causing “Maximum call stack size exceeded” error #1775

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/install/deps.js
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ function isDepOptional (tree, name, pkg) {
}

exports.failedDependency = failedDependency
function failedDependency (tree, name, pkg) {
function failedDependency (tree, name, pkg, done) {
if (name) {
if (isDepOptional(tree, name, pkg || {})) {
return false
Expand All @@ -451,10 +451,13 @@ function failedDependency (tree, name, pkg) {

if (!tree.requiredBy) return false

done = done || {}
done[tree] = true

let anyFailed = false
for (var ii = 0; ii < tree.requiredBy.length; ++ii) {
var requireParent = tree.requiredBy[ii]
if (failedDependency(requireParent, moduleName(tree), tree)) {
if (!done[requireParent] && failedDependency(requireParent, moduleName(tree), tree, done)) {
anyFailed = true
}
}
Expand Down