Fix infinite recursion bug causing “Maximum call stack size exceeded” error #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fadoli
reviewed
Oct 7, 2020
lib/install/deps.js
Outdated
| let anyFailed = false | ||
| for (var ii = 0; ii < tree.requiredBy.length; ++ii) { | ||
| var requireParent = tree.requiredBy[ii] | ||
| if (failedDependency(requireParent, moduleName(tree), tree)) { | ||
| if (!doneList[requireParent] && failedDependency(requireParent, moduleName(tree), tree, done)) { |
There was a problem hiding this comment.
this should be
if (!doneList[requireParent] && failedDependency(requireParent, moduleName(tree), tree, doneList)) {
There was a problem hiding this comment.
Thanks. I fixed this by using done everywhere, to match the coding style of loadRequestedDeps() or getAllMetadata in the same file.
There was a problem hiding this comment.
done is actually a keyword used for callback in most js program so it was better with the older variable name.
I'm not a maintainer of this project, and it doesn't seems like one of them is looking at this PR anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling e.g.
npm install,failedDependency()has a potential unchecked infinite recursive call, causingnpmto crash in some situations, when circular dependencies are involved.I believe this PR fixes the bug, let me know of anything I can do to improve it if necessary.
References
As a Google search indicates, dozens if not hundreds of users have reported issues related to this overflow, it even appears to cause BSODs. The underlying bug has never been really investigated and some of these issues have been closed due to inactivity, or due to users clearing their
npmcache, or managing to install packages through a slightly different invocation.