This repository has been archived by the owner on Jan 25, 2025. It is now read-only.
Comments #76
Merged
Comments #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sumnerevans
added a commit
to sumnerevans/chess
that referenced
this pull request
Dec 12, 2021
There were two main bugs that this fixes. * Fixes notnil#77: fixed parsing of PGNs where there is no space after the move number indicator. This used to work, but notnil#76 caused a regression. * Fixes notnil#78: using the regular expression allows for comments that don't have spaces separating the `{` and `}` tokens.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comments support (needed for parsing the Lichess Database eval values https://database.lichess.org). It also refactors the PGN tests a bit.