This repository has been archived by the owner on Jan 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 135
PGN reader is not compatible with cutechess-cli #78
Comments
amanjpro
pushed a commit
to amanjpro/chess
that referenced
this issue
Sep 6, 2021
Fixes issue notnil#78
This was referenced Sep 6, 2021
Closed
@amanjpro after reviewing the issue, it appears that the previous code only handles comments with spaces. |
I agree it's a hack, I only did it to unblock myself for my engine... I appreciate a cleaner solution :) I love this library and will soon use it for my other projects ;) |
sumnerevans
added a commit
to sumnerevans/chess
that referenced
this issue
Dec 12, 2021
There were two main bugs that this fixes. * Fixes notnil#77: fixed parsing of PGNs where there is no space after the move number indicator. This used to work, but notnil#76 caused a regression. * Fixes notnil#78: using the regular expression allows for comments that don't have spaces separating the `{` and `}` tokens.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reading this PGN:
Will result in this error:
The text was updated successfully, but these errors were encountered: