Support custom knowledge base #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondaychen
reviewed
Mar 25, 2024
There was a problem hiding this comment.
- Please address type errors and warnings.
- I don't see redirects. I think we either need to store custom redirects, or make www.example.com and example.com point to each other automatically (do the same build-in knowledge base)
- we should think about how people can use the settings others share. Maybe add a view that allows freeform JSON editing (of course we'll need to validate before save)
…pe to avoid conflict
18c7a2a to
fe54283
Compare
990e3c9 to
6d11ff9
Compare
lynchee-owo
commented
Mar 27, 2024
| @@ -158,6 +158,7 @@ const Settings = ({ setInSettingsView }: SettingsProps) => { | |||
| <FormLabel mb="0">Turn On Voice Mode</FormLabel> | |||
| <Spacer /> | |||
| <Switch | |||
| id="voiceModeSwitch" | |||
There was a problem hiding this comment.
I added an id here because without this, clicking any formLabel in settings would trigger switch even though there's no htmlFor
mondaychen
reviewed
Mar 28, 2024
mondaychen
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO in the future. not in scope of this pr
<FastField />when the new knowledge form gets very complicated (30+ fields)solve #57