fix: minor UI tweak

normal-computing · Mar 27, 2024 · 6d11ff9 · 6d11ff9
1 parent fafe209
commit 6d11ff9
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 31 deletions.
diff --git a/src/common/NewKnowledgeForm.tsx b/src/common/NewKnowledgeForm.tsx
@@ -183,6 +183,7 @@ const NewKnowledgeForm = ({
                     size="sm"
                     colorScheme="red"
                     variant="ghost"
+                    zIndex="docked"
                     onClick={() => {
                       const updatedRules = values.rules.filter(
                         (_, idx) => idx !== ruleIndex,
@@ -221,21 +222,23 @@ const NewKnowledgeForm = ({
                           placeholder="Enter regex to match pathname"
                         />
                         <InputRightElement>
-                          <IconButton
-                            aria-label="Remove regex"
-                            icon={<SmallCloseIcon />}
-                            variant="ghost"
-                            onClick={() => {
-                              const updatedRegexes = [
-                                ...values.rules[ruleIndex].regexes,
-                              ];
-                              updatedRegexes.splice(regexIndex, 1);
-                              setFieldValue(
-                                `rules[${ruleIndex}].regexes`,
-                                updatedRegexes,
-                              );
-                            }}
-                          />
+                          {rule.regexes.length > 1 && (
+                            <IconButton
+                              aria-label="Remove regex"
+                              icon={<SmallCloseIcon />}
+                              variant="ghost"
+                              onClick={() => {
+                                const updatedRegexes = [
+                                  ...values.rules[ruleIndex].regexes,
+                                ];
+                                updatedRegexes.splice(regexIndex, 1);
+                                setFieldValue(
+                                  `rules[${ruleIndex}].regexes`,
+                                  updatedRegexes,
+                                );
+                              }}
+                            />
+                          )}
                         </InputRightElement>
                       </InputGroup>
                     </FormControl>
@@ -271,22 +274,25 @@ const NewKnowledgeForm = ({
                         placeholder="Enter note"
                       />
                       <InputRightElement>
-                        <IconButton
-                          aria-label="Remove note"
-                          icon={<SmallCloseIcon />}
-                          variant="ghost"
-                          onClick={() => {
-                            const updatedNotes = [
-                              ...(values.rules[ruleIndex].knowledge.notes ||
-                                []),
-                            ];
-                            updatedNotes.splice(noteIndex, 1);
-                            setFieldValue(
-                              `rules[${ruleIndex}].knowledge.notes`,
-                              updatedNotes,
-                            );
-                          }}
-                        />
+                        {rule.knowledge.notes &&
+                          rule.knowledge.notes.length > 1 && (
+                            <IconButton
+                              aria-label="Remove note"
+                              icon={<SmallCloseIcon />}
+                              variant="ghost"
+                              onClick={() => {
+                                const updatedNotes = [
+                                  ...(values.rules[ruleIndex].knowledge.notes ||
+                                    []),
+                                ];
+                                updatedNotes.splice(noteIndex, 1);
+                                setFieldValue(
+                                  `rules[${ruleIndex}].knowledge.notes`,
+                                  updatedNotes,
+                                );
+                              }}
+                            />
+                          )}
                       </InputRightElement>
                     </InputGroup>
                   ))}

diff --git a/src/common/Settings.tsx b/src/common/Settings.tsx
@@ -158,6 +158,7 @@ const Settings = ({ setInSettingsView }: SettingsProps) => {
             <FormLabel mb="0">Turn On Voice Mode</FormLabel>
             <Spacer />
             <Switch
+              id="voiceModeSwitch"
               isChecked={state.voiceMode}
               onChange={(e) => {
                 const isEnabled = e.target.checked;