Improve logging #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chilagrow
commented
Jun 28, 2024
| if err != nil { | ||
| l.Fatal("Connection failed", zap.Error(err)) | ||
| logger.Fatal("Connection failed.", zap.Error(err)) |
There was a problem hiding this comment.
Using logger.Fatal(...) uses zap.Field appropriately like this
FATAL ferretdb/main.go:375 Connection failed. {"error": "some error"}
Sugared l.Fatal(...) is expected for Fatalf usage, so error displayed string concatenated and isn't friendly.
FATAL ferretdb/main.go:375 Connection failed.{error 26 0 some error}
9 tasks
AlekSi
reviewed
Jun 28, 2024
Comment on lines
+113
to
+114
| redactedURL := u.Redacted() | ||
| l.Debugf("Pinging %s...", redactedURL) |
noisersup
reviewed
Jun 28, 2024
| } | ||
|
|
||
| if cli.Listen.Unix != "" { | ||
| l.Debugf("--listen-unix flag is set. Ping to %s will be performed.", cli.Listen.Unix) | ||
|
|
||
| urls = append(urls, "mongodb://"+url.PathEscape(cli.Listen.Unix)) | ||
| urls = append(urls, &url.URL{Scheme: "mongodb", Path: url.PathEscape(cli.Listen.Unix)}) |
There was a problem hiding this comment.
I've actually tried to implement it like that before, but unfortunately url.URL is not meant for unix socket as it escapes % from the url.PathEscape. It doesn't escape '/' though, so it's not possible to not use PathEscape function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #<issue_number>.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.