Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Docker healthcheck #4364

Merged
merged 54 commits into from
Jul 2, 2024

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jun 14, 2024

Description

Closes #4246.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.89%. Comparing base (79834b0) to head (7225f05).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4364      +/-   ##
==========================================
- Coverage   74.14%   73.89%   -0.25%     
==========================================
  Files         323      323              
  Lines       22447    22447              
==========================================
- Hits        16643    16587      -56     
- Misses       4579     4638      +59     
+ Partials     1225     1222       -3     

see 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.35% <ø> (-0.30%) ⬇️
hana-1 ?
integration 67.35% <ø> (-0.30%) ⬇️
mongodb-1 5.20% <ø> (ø)
postgresql-1 43.95% <ø> (-0.01%) ⬇️
postgresql-2 44.98% <ø> (+0.08%) ⬆️
postgresql-3 43.03% <ø> (+0.03%) ⬆️
postgresql-4 40.31% <ø> (+<0.01%) ⬆️
postgresql-5 43.80% <ø> (+0.05%) ⬆️
sqlite-1 43.16% <ø> (ø)
sqlite-2 44.06% <ø> (ø)
sqlite-3 42.25% <ø> (+0.02%) ⬆️
sqlite-4 39.46% <ø> (+<0.01%) ⬆️
sqlite-5 43.07% <ø> (+0.02%) ⬆️
unit 32.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are merge conflicts now

Copy link
Contributor

mergify bot commented Jun 19, 2024

@noisersup this pull request has merge conflicts.

@noisersup noisersup requested review from AlekSi and chilagrow June 27, 2024 15:10
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I didn't get across what I meant about comments related to logging. Codified the suggestion noisersup#5

@noisersup noisersup requested a review from chilagrow June 28, 2024 11:35
chilagrow
chilagrow previously approved these changes Jul 1, 2024
@noisersup noisersup requested review from AlekSi and chilagrow July 1, 2024 19:37
@AlekSi AlekSi added this to the v1.23.0 milestone Jul 2, 2024
@AlekSi
Copy link
Member

AlekSi commented Jul 2, 2024

Milestone wasn't set

@noisersup noisersup merged commit 7845441 into FerretDB:main Jul 2, 2024
33 of 34 checks passed
@AlekSi AlekSi added code/feature Some user-visible feature is not implemented yet and removed code/chore Code maintenance improvements labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement Docker's HEALTHCHECK
4 participants