feat: simplify assertions that squared values are equal to zero #7432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was going to suggest adding a test but I wasn't sure it was possible, but it is with |
asterite
approved these changes
Feb 19, 2025
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 19, 2025
chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (noir-lang/noir#7426) chore: simplify reports (noir-lang/noir#7421) fix: do not discard negative sign from field literals in comptime interpreter (noir-lang/noir#7439) chore: bump aztec-packages commit (noir-lang/noir#7441) fix: require loop/for/while body to be unit (noir-lang/noir#7437) feat: simplify assertions that squared values are equal to zero (noir-lang/noir#7432) chore(benchmark): Improve noir msm benchmark (noir-lang/noir#7390) chore: Add SSA security checks description (noir-lang/noir#7366)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 19, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat(cli): add noir-execute binary (noir-lang/noir#7384) chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (noir-lang/noir#7426) chore: simplify reports (noir-lang/noir#7421) fix: do not discard negative sign from field literals in comptime interpreter (noir-lang/noir#7439) chore: bump aztec-packages commit (noir-lang/noir#7441) fix: require loop/for/while body to be unit (noir-lang/noir#7437) feat: simplify assertions that squared values are equal to zero (noir-lang/noir#7432) chore(benchmark): Improve noir msm benchmark (noir-lang/noir#7390) chore: Add SSA security checks description (noir-lang/noir#7366) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Something I noticed when reviewing #7301
Summary*
We currently don't simplify
into
I've then added this as an optimization when decomposing constraints.
This looks like it should be safe to me due to us using a prime field so there's no nonzero solutions to
v0 * v0 == 0.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.