-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add SSA security checks description #7366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://67b599289a838ae6121b5012--noir-docs.netlify.app |
michaeljklein
requested changes
Feb 13, 2025
michaeljklein
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small optional rewording.
Co-authored-by: Michael J Klein <michaeljklein@users.noreply.github.com>
FYI @noir-lang/developerrelations on Noir doc changes. |
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 19, 2025
chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (noir-lang/noir#7426) chore: simplify reports (noir-lang/noir#7421) fix: do not discard negative sign from field literals in comptime interpreter (noir-lang/noir#7439) chore: bump aztec-packages commit (noir-lang/noir#7441) fix: require loop/for/while body to be unit (noir-lang/noir#7437) feat: simplify assertions that squared values are equal to zero (noir-lang/noir#7432) chore(benchmark): Improve noir msm benchmark (noir-lang/noir#7390) chore: Add SSA security checks description (noir-lang/noir#7366)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 19, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat(cli): add noir-execute binary (noir-lang/noir#7384) chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (noir-lang/noir#7426) chore: simplify reports (noir-lang/noir#7421) fix: do not discard negative sign from field literals in comptime interpreter (noir-lang/noir#7439) chore: bump aztec-packages commit (noir-lang/noir#7441) fix: require loop/for/while body to be unit (noir-lang/noir#7437) feat: simplify assertions that squared values are equal to zero (noir-lang/noir#7432) chore(benchmark): Improve noir msm benchmark (noir-lang/noir#7390) chore: Add SSA security checks description (noir-lang/noir#7366) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a short description of the SSA security passes in
docs/docs/tooling/security.md
(per @Rumata888's suggestion).Problem
Resolves #6707
Summary
Additional Context
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.