Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Bundle SSA Evaluator Options #4667

Closed
vezenovm opened this issue Mar 28, 2024 · 0 comments · Fixed by #5317
Closed

Chore: Bundle SSA Evaluator Options #4667

vezenovm opened this issue Mar 28, 2024 · 0 comments · Fixed by #5317
Assignees
@asterite
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vezenovm
Copy link
Contributor

vezenovm commented Mar 28, 2024 •
edited
Loading

Problem

After this PR (#4659) we have started to have a lot of boolean flags passed down into SSA from our compile options.

Happy Case

We should structure these flags into a contained struct as to not clutter function signatures.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@vezenovm vezenovm added enhancement New feature or request good first issue Good for newcomers labels Mar 28, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 28, 2024
@vezenovm vezenovm mentioned this issue Mar 28, 2024
Merged
5 tasks
@asterite asterite mentioned this issue Jun 24, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 24, 2024
@asterite @TomAFrench
chore: Bundle SSA Evaluator Options (#5317)
42d727f 
Better reviewed with "Diff -> Hide whitespace".

# Description

## Problem

Resolves #4667

## Summary

Introduces an `SsaEvaluatorOptions` struct that bundles a bunch of
booleans that are passed down several functions.

## Additional Context

None

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asterite asterite

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Bundle SSA Evaluator Options noir-lang/noir
2 participants
@asterite @vezenovm