Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sidekiq from 5.2.9 to 6.2.1 #5

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github May 26, 2021

Bumps sidekiq from 5.2.9 to 6.2.1.

Changelog

Sourced from sidekiq's changelog.

6.2.1

  • Update RTT warning logic to handle transient RTT spikes #4851
  • Fix very low priority CVE on unescaped queue name #4852
  • Add note about sessions and Rails apps in API mode

6.2.0

  • Store Redis RTT and log if poor #4824
  • Add process/thread stats to Busy page #4806
  • Improve Web UI on mobile devices #4840
  • Refactor Web UI session usage #4804 Numerous people have hit "Forbidden" errors and struggled with Sidekiq's Web UI session requirement. If you have code in your initializer for Web sessions, it's quite possible it will need to be removed. Here's an overview:
Sidekiq::Web needs a valid Rack session for CSRF protection. If this is a Rails app,
make sure you mount Sidekiq::Web *inside* your routes in `config/routes.rb` so
Sidekiq can reuse the Rails session:

Rails.application.routes.draw do mount Sidekiq::Web => "/sidekiq" .... end

If this is a bare Rack app, use a session middleware before Sidekiq::Web:

first, use IRB to create a shared secret key for sessions and commit it

require 'securerandom'; File.open(".session.key", "w") {|f| f.write(SecureRandom.hex(32)) }

now, update your Rack app to include the secret with a session cookie middleware

use Rack::Session::Cookie, secret: File.read(".session.key"), same_site: true, max_age: 86400 run Sidekiq::Web

If this is a Rails app in API mode, you need to enable sessions.

https://guides.rubyonrails.org/api_app.html#using-session-middlewares

6.1.3

  • Warn if Redis is configured to evict data under memory pressure #4752
  • Add process RSS on the Busy page #4717

6.1.2

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels May 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #5 (5152fad) into main (76422d1) will increase coverage by 54.82%.
The diff coverage is 83.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   27.19%   82.01%   +54.82%     
===========================================
  Files         100       98        -2     
  Lines        7586     5928     -1658     
===========================================
+ Hits         2063     4862     +2799     
+ Misses       5523     1066     -4457     
Impacted Files Coverage Δ
app/controllers/application_controller.rb 90.42% <ø> (+67.14%) ⬆️
app/controllers/map_controller.rb 50.00% <ø> (+50.00%) ⬆️
app/controllers/questions_controller.rb 89.18% <0.00%> (+89.18%) ⬆️
app/controllers/users_controller.rb 80.29% <33.33%> (+80.29%) ⬆️
app/controllers/comment_controller.rb 78.57% <57.14%> (+78.57%) ⬆️
app/models/user.rb 86.13% <62.50%> (+7.45%) ⬆️
app/models/node.rb 91.02% <81.81%> (+12.17%) ⬆️
app/models/comment.rb 77.63% <82.35%> (+14.96%) ⬆️
app/controllers/wiki_controller.rb 82.85% <87.50%> (+82.85%) ⬆️
app/controllers/tag_controller.rb 80.55% <88.88%> (+80.55%) ⬆️
... and 77 more

@dependabot dependabot bot force-pushed the dependabot/bundler/sidekiq-6.2.1 branch from 972cd4f to 5152fad Compare June 1, 2021 22:33
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Aug 23, 2021

Superseded by #49.

@dependabot dependabot bot closed this Aug 23, 2021
@dependabot dependabot bot deleted the dependabot/bundler/sidekiq-6.2.1 branch August 23, 2021 18:21
noi5e pushed a commit that referenced this pull request Apr 18, 2022
* Removed duplicate code publiclab#10897

* Removed duplicate code publiclab#10897

* Indented Line

* Removed Duplicate Code publiclab#10897 Fix

Indented line #5 to be on same line as #10

* Removed Duplicate Code publiclab#10897 Fix

Indented line #5 to be on same line as #10

* Indentation on #5 fix

* Removed Duplicate Code publiclab#10897 Fix

Indented line #5 to be on same line as #10

* Removed duplicate code publiclab#10897

Removed Duplicate code publiclab#10987 Indenting Line #5

* Removed Duplicate Code publiclab#10897 Fix

Indented line #5 to be on same line as #10

* Indentation on #5 fix

* Removed Duplicate Code publiclab#10897 Fix

Indented line #5 to be on same line as #10

* Removed duplicate code publiclab#10897

Removed Duplicate code publiclab#10987 Indenting Line #5

* Removed Duplicate Code publiclab#10897 Fix

Indented line #5 to be on same line as #10

* Indentation on #5 fix

* Removed duplicate code publiclab#10897

* Indented Line

* Removed duplicate code publiclab#10897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant