Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code #10969

Merged
merged 21 commits into from
Apr 7, 2022
Merged

Conversation

rohaid-bakh
Copy link
Contributor

@rohaid-bakh rohaid-bakh commented Apr 6, 2022

I removed a section of code in Spam2/_nodes.html.erb and added select_all() that selects all buttons.
#10897
Fixes #10897

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

This should be handed off to #10952 when possible, thank you

rohaid-bakh and others added 21 commits April 3, 2022 21:49
@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 6, 2022

Code Climate has analyzed commit 0bcd353 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5962592906/artifacts/204860254

@rohaid-bakh
Copy link
Contributor Author

rohaid-bakh commented Apr 7, 2022

@TildaDares @jywarren I'd appreciate it if I could get this pull request reviewed, thank you.

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohaid-bakh!! Great work.

@TildaDares TildaDares merged commit 7898005 into publiclab:main Apr 7, 2022
@welcome
Copy link

welcome bot commented Apr 7, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Congratulations @rohaid-bakh!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Duplicate Code in Spam2
2 participants