-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate code #10969
Remove duplicate code #10969
Conversation
Indented line publiclab#5 to be on same line as publiclab#10
Indented line publiclab#5 to be on same line as publiclab#10
Indented line publiclab#5 to be on same line as publiclab#10
Removed Duplicate code publiclab#10987 Indenting Line publiclab#5
Indented line publiclab#5 to be on same line as publiclab#10
… into remove-duplicate-code
Indented line publiclab#5 to be on same line as publiclab#10
Removed Duplicate code publiclab#10987 Indenting Line publiclab#5
Indented line publiclab#5 to be on same line as publiclab#10
Code Climate has analyzed commit 0bcd353 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
@TildaDares @jywarren I'd appreciate it if I could get this pull request reviewed, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rohaid-bakh!! Great work.
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congratulations @rohaid-bakh!! |
I removed a section of code in Spam2/_nodes.html.erb and added select_all() that selects all buttons.
#10897
Fixes #10897
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowThis should be handed off to #10952 when possible, thank you