Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: database queries reduction #511

Merged
merged 13 commits into from
Feb 1, 2025
Merged

refactor: database queries reduction #511

merged 13 commits into from
Feb 1, 2025

Conversation

jon-nfc
Copy link
Member

@jon-nfc jon-nfc commented Jan 31, 2025

📚 Summary

🔗 Links / References

👷 Tasks

  • Add your tasks here if required (delete)

  • Feature Release ONLY 🟥 Squash migration files 🟥
    Multiple migration files created as part of this release are to be sqauashed into a few files as possible so as to limit the number of migrations

  • 🧨 Contains breaking-change Any Breaking change(s)?

    Breaking Change must also be notated in the commit that introduces it and in Conventional Commit Format.

    • 📓 Release notes updated

  • 📘 Documentation written

    All features to be documented within the correct section(s). Administration, Development and/or User

  • 🏁 Milestone assigned

  • ⚙️ 🧪 Functional Test(s) Written

  • 🧪 Unit Test(s) Written

    ensure test coverage delta is not less than zero

  • 📄 Roadmap updated

@jon-nfc jon-nfc added this to the Next Release milestone Jan 31, 2025
@jon-nfc jon-nfc self-assigned this Jan 31, 2025
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from 75ab245 to c27bbf0 Compare January 31, 2025 12:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

Python Scan Results (requirements.txt)

Scan Date: 2025-02-01T08:26:54.321813676Z
File: requirements.txt

Nothing Found

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

Image Scan Results

Scan Date: 2025-02-01T08:34:36.600623127Z
Image: ghcr.io/nofusscomputing/centurion-erp:b419c037740b1a4460982c14e330cc92504d8ae3
OS: alpine 3.20.3

Nothing Found

jon-nfc added a commit that referenced this pull request Jan 31, 2025
@jon-nfc
feat: Views to cache discovered serializer
d86cc8a 
ref: #471 #511
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from c27bbf0 to d86cc8a Compare January 31, 2025 13:10
jon-nfc added a commit that referenced this pull request Jan 31, 2025
@jon-nfc
feat: Views to cache discovered serializer
b2b9eaf 
ref: #471 #511
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from d86cc8a to b2b9eaf Compare January 31, 2025 13:24
jon-nfc added a commit that referenced this pull request Jan 31, 2025
@jon-nfc
refactor(access): Whilst attempting to get object org, check and use …
bee6b34 
…pk if exists

ref: #471 #511
jon-nfc added a commit that referenced this pull request Jan 31, 2025
@jon-nfc
refactor(access): Permission Mixin has_paermission to use view attrib…
062708d 
…ute for object org

ref: #471 #511
jon-nfc added a commit that referenced this pull request Jan 31, 2025
@jon-nfc
refactor(core): When fetching a ticket, fetch related fields
f198cd0 
ref: #471 #511
jon-nfc added a commit that referenced this pull request Jan 31, 2025
@jon-nfc
fix(core): ensure ite_type exists before trying to get queryset
11d844e 
ref: #471 #511
jon-nfc added a commit that referenced this pull request Jan 31, 2025
@jon-nfc
test(access): during permission check function has_permission ensure …
9a8c44c 
…`get_object` not called

ref: #471 #511
jon-nfc added a commit that referenced this pull request Jan 31, 2025
@jon-nfc
test(access): during permission check function has_permission ensure …
3d9a1bc 
…`get_object` not called

ref: #471 #511
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from 9a8c44c to 3d9a1bc Compare January 31, 2025 14:05
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
fix(core): ensure item_type exists before trying to get queryset
1623187 
ref: #471 #511
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from 3d9a1bc to 1623187 Compare February 1, 2025 05:12
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from 1623187 to 3adb935 Compare February 1, 2025 05:18
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
fix(core): ensure item_type exists before trying to get queryset
8af2d3e 
ref: #471 #511
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
fix(core): during permission checking, only call obj_org once
3adb935 
ref: #471 #511
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
fix(core): ensure item_type exists before trying to get queryset
dbebdaf 
ref: #471 #511
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from 3adb935 to dbebdaf Compare February 1, 2025 05:26
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
fix(core): during permission checking, only call obj_org once
d6cdffd 
ref: #471 #511
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
test(access): during permission check function has_permission ensure …
66aa8d9 
…`get_object` not called

ref: #471 #511
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
refactor(access): Permission Mixin has_permission to use view attribu…
9b7d7d3 
…te for object org

ref: #471 #511
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from 9b7d7d3 to e5b0ed4 Compare February 1, 2025 05:58
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
refactor(access): Whilst attempting to get object org, check and use …
10b8b47 
…pk if exists

ref: #471 #511
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
refactor(access): Permission Mixin has_permission to use view attribu…
18437b3 
…te for object org

ref: #471 #511
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from 18437b3 to 869f0d1 Compare February 1, 2025 06:29
jon-nfc added a commit that referenced this pull request Feb 1, 2025
@jon-nfc
chore(access): Remove extra calls to get_obj_permission from permis…
869f0d1 
…sion Mixin has_permission

ref: #471 #511
@jon-nfc jon-nfc force-pushed the db-queries-reduction branch from 869f0d1 to 22b02dc Compare February 1, 2025 06:57
@jon-nfc
chore(access): Remove extra calls to get_obj_permission from permis…
f9393a5 
…sion Mixin has_permission

ref: #471 #511
@jon-nfc
refactor(access): when checking obj permission use view cached obj or…
b6593c6 
…ganization

ref: #471 #511
@jon-nfc
fix(access): org mixin get_obj_org not to call get_object
a4788ab 
ref: #471 #511
@jon-nfc
test(access): during permission check function has_permission ensure …
5507c4a 
…`get_object` not called

ref: #471 #511
@jon-nfc
test(settings): regardless of permissions a user can change their own…
78afe7c 
… settings

ref: #471 #511
@jon-nfc
fix(access): when checking object permissions, dont cast obj to int u…
b7cdb21 
…ntill checking it exists

ref: #471 #511
@jon-nfc
test(settings): when checking if user can delete own settings, user m…
1ad370e 
…ust be owner of settings

ref: #471 #511
@jon-nfc
fix(access): When conduting permission check for user settings, if us…
b419c03 
…er not owner of settings, deny access

ref: #471 #511
@jon-nfc jon-nfc merged commit 1488c6e into feature-next-release Feb 1, 2025
56 checks passed
@jon-nfc jon-nfc deleted the db-queries-reduction branch February 1, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jon-nfc jon-nfc

Labels
task::refactor
Projects
Centurion ERP
Status: Done
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
1 participant
@jon-nfc